regsort handle the case when no cycle and xchg=False incorrectly.

[peter50216]

>>> from pwn import *
>>> regsort({'a': 'b', 'b': 'c'}, ['a', 'b', 'c'])
[('mov', 'a', 'b'), ('mov', 'b', 'c')]
>>> regsort({'a': 'b', 'b': 'c'}, ['a', 'b', 'c'], xchg=False)
[('mov', 'b', 'c'), ('mov', 'a', 'b')]

Both output should be same.

[zachriggle]

Holy cow, I'm impressed anybody ever dug into that code! Thanks for reporting the bug, I'll look tomorrow! Out of curiosity, we experienced a spike in reports this week -- did pwntools come up in media somewhere?

…

On Thu, Jan 12, 2017 at 12:25 AM Peter Shih ***@***.***> wrote: >>> from pwn import *>>> regsort({'a': 'b', 'b': 'c'}, ['a', 'b', 'c']) [('mov', 'a', 'b'), ('mov', 'b', 'c')]>>> regsort({'a': 'b', 'b': 'c'}, ['a', 'b', 'c'], xchg=False) [('mov', 'b', 'c'), ('mov', 'a', 'b')] Both output should be same. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#847>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG0GGG6r_qg0-cIkyWDqF4Cix5y_sw_ks5rRblGgaJpZM4LhYhi> .

[peter50216]

For the reports by me or @david942j, it's because we're trying to write pwntools for Ruby :D
(https://github.com/peter50216/pwntools-ruby)

[zachriggle]

Fixed via #852