Add cyclic default args to context #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, this adds context.cyclic_alphabet and context.cyclic_size This helps cut down on writing "n=8" all the time for users who use 8-byte subsequences on 64-bit architectures. Exposing the default alphabet means that users can avoid "bad bytes" in cyclic patterns which are generated by pwntools internally (e.g. ROP padding) Some pwnlib.util.packing docstrings were changed to clarify that word_size is in bits. The doctests in pwnlib.util.cyclic were updated and extended to have more and better doctests, as well as better exaples.
zachriggle
force-pushed
the
cyclic-context
branch
from
c052644 to
486560d
Compare
|
@idolf A small change which I think may have been a bug is that the old code used The old behavior is pretty clearly wrong: >>> cyclic_find(0, alphabet=unhex('DEADBEEF00'))
4
>>> cyclic(16, alphabet=unhex('DEADBEEF00'))
'\xde\xde\xde\xde\xad\xde\xde\xde\xbe\xde\xde\xde\xef\xde\xde\xde' |
This is important because old code would use pack(..., "all") when an integer value was provided, instead of using the correct width.
zachriggle
force-pushed
the
cyclic-context
branch
from
3173a86 to
61f2da3
Compare
|
I don't really have the cycles to check if this is correct -- but you've added tests so I'm inclined to trust you. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, this adds
context.cyclic_alphabetandcontext.cyclic_sizeThis helps cut down on writing
n=8all the time for users who use 8-bytesubsequences on 64-bit architectures.
Exposing the default alphabet means that users can avoid "bad bytes" in
cyclic patterns which are generated by pwntools internally (e.g. ROP padding)
Some
pwnlib.util.packingdocstrings were changed to clarify that word_size isin bits.
The doctests in
pwnlib.util.cyclicwere updated and extended to have moreand better doctests, as well as better exaples.