Fix races in server tube from #1067 and apply #1569 #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason to change the default to ipv6? |
|
Just as explained in #1569, v6 allows receiving v4 connections on a mapped range, but not the other way round. So the default is now to listen on both, whereas it's been v4 only so far. |
|
Sounds fair to me, it just stood out as an odd change given the PR. Makes sense now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The events were used in a racy way, which was not necessary at all, since python already has an atomic queue interface.
Also,
famparsing is not necessary, since the magic conversion methods already do the trick.Furthermore, #1552 also affected
servertubes, which was not mentioned in its description.