Reorder shellcraft syscall templates #880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like it requires more maintenance than #871, and doesn't have any way of bulk updating (e.g. If there is an error in the template). #871 also supports complex types, so that shellcraft.i386.linux.read("/home/challenge/flag") works as expected. Take a look at the generation script in #871 to see what I mean: https://github.com/zachriggle/pwntools/tree/c48e6b08f04f64d283232f5dd37ee95743ffc150/pwnlib/data/syscalls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move autogenerated syscall shellcode into
syscalls/directories, making it easier to see the handwritten shellcode. Solves issue #685.Based on #712 , which I closed because it was easier to merge with current dev by hand.
I'm sorry for the extra work this causes for #871. If it's easier, then feel free to disregard this and/or cherry pick stuff into that pull request instead.