Start on a mechanism to build Cryptol values from outside Cryptol #1739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan here is to add a mechanism that allows the Cryptol interpreter to cooperate with an external function to build Cryptol values, which would help support more forms of FFI.
Our current FFI to C assumes a fixed data layout for values, and it is the job of Cryptol to parse the values back into Cryptol values, when results a returned by a foreign function.
The new approach exposes a "Cryptol value builder" object to the foreign function, so that the foreign function can build the Cryptol values itself. The benefit of this is that we only need to impose representation constraints on primitve types (e.g., bool, integer, word), while the representation of compound values types (e.g., vectors, tuples, sums) is unrestricted.