Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty-printing for uinc_wrap and udec_wrap is incorrect #139

Closed
RyanGlScott opened this issue Jul 25, 2024 · 0 comments · Fixed by #140
Closed

Pretty-printing for uinc_wrap and udec_wrap is incorrect #139

RyanGlScott opened this issue Jul 25, 2024 · 0 comments · Fixed by #140
Labels
bug Something isn't working llvm/16.0

Comments

@RyanGlScott
Copy link
Collaborator

#138 added support for the atomic uinc_wrap and udec_wrap operations, but the pretty-printing code is incorrect:

llvm-pretty/src/Text/LLVM/PP.hs

Lines 563 to 564 in a815d8c

ppAtomicOp AtomicUIncWrap = onlyOnLLVM 16 "AtomicUIncWrap" "uincwrap"
ppAtomicOp AtomicUDecWrap = onlyOnLLVM 16 "AtomicUDecWrap" "udecwrap"

Per the LLVM commit which introduced these operations, these should be printed as uinc_wrap and udec_wrap, not uincwrap and udecwrap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working llvm/16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pretty-printing for uinc_wrap and udec_wrap GaloisInc/llvm-pretty
1 participant
@RyanGlScott