Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update internal damping values for rod-rigid body contact cases #171

Closed
bhosale2 opened this issue Aug 7, 2022 · 1 comment · Fixed by #172
Closed

Update internal damping values for rod-rigid body contact cases #171

bhosale2 opened this issue Aug 7, 2022 · 1 comment · Fixed by #172
Assignees
@bhosale2
Labels
prio:high Priority level: high update Update the codebase
Milestone
Version 0.3

Comments

@bhosale2
Copy link
Collaborator

bhosale2 commented Aug 7, 2022

Since rod-rigid body contact cases were developed in v0.2.4, the internal damping values are based on the old model. If possible before the next release, the values need to be updated to be consistent with the new model, to simulate expected dynamics.
@bhosale2 bhosale2 added update Update the codebase prio:high Priority level: high labels Aug 7, 2022
@bhosale2 bhosale2 added this to the Version 0.3 milestone Aug 7, 2022
@bhosale2 bhosale2 self-assigned this Aug 7, 2022
@bhosale2 bhosale2 mentioned this issue Aug 7, 2022
Merged
@bhosale2 bhosale2 linked a pull request Aug 7, 2022 that will close this issue
update: Damping values for rod-rigid body contact cases (#171) #172
Merged
armantekinalp added a commit that referenced this issue Aug 10, 2022
@armantekinalp
Merge pull request #172 from bhosale2/171_update_internal_damping_rod…
67c3b9e 
…_rigid_body

update: Damping values for rod-rigid body contact cases (#171)
@bhosale2
Copy link
Collaborator Author

Closed via #172.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhosale2 bhosale2

Labels
prio:high Priority level: high update Update the codebase
Projects
None yet
Milestone
Version 0.3
Development

Successfully merging a pull request may close this issue.

update: Damping values for rod-rigid body contact cases (#171) bhosale2/PyElastica
1 participant
@bhosale2