Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase significant digits of shear coefficient #79

Closed
armantekinalp opened this issue May 11, 2022 · 1 comment · Fixed by #82
Closed

Increase significant digits of shear coefficient #79

armantekinalp opened this issue May 11, 2022 · 1 comment · Fixed by #82
Assignees
@bhosale2
Labels
good first issue Good for newcomers invalid This doesn't seem right update Update the codebase
Milestone
Version 0.3

Comments

@armantekinalp
Copy link
Contributor

Shear coefficient for circular cross-section can be computed as 27/28 using the formula given in Kandro 1975 Figure 2 Correlation A.

PyElastica/elastica/rod/factory_function.py

Lines 221 to 222 in fee87b9

# "On Timoshenko's correction for shear in vibrating beams" by Kaneko, 1975
alpha_c = kwargs.get("alpha_c", 0.964)

How to fix: change shear coefficient as 27./28. .
@armantekinalp armantekinalp added good first issue Good for newcomers invalid This doesn't seem right update Update the codebase labels May 11, 2022
@armantekinalp armantekinalp added this to the Version 0.3 milestone May 11, 2022
@bhosale2 bhosale2 self-assigned this May 11, 2022
@bhosale2 bhosale2 mentioned this issue May 12, 2022
Merged
@bhosale2 bhosale2 linked a pull request May 12, 2022 that will close this issue
Adds significant digits to shear coefficient (#79) #82
Merged
bhosale2 added a commit that referenced this issue May 12, 2022
@bhosale2
Merge pull request #82 from bhosale2/79_shear_coeff_significant_digits
a0e7ce5 
Adds significant digits to shear coefficient (#79)
@bhosale2
Copy link
Collaborator

Closed via #82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhosale2 bhosale2

Labels
good first issue Good for newcomers invalid This doesn't seem right update Update the codebase
Projects
None yet
Milestone
Version 0.3
Development

Successfully merging a pull request may close this issue.

Adds significant digits to shear coefficient (#79) bhosale2/PyElastica
2 participants
@bhosale2 @armantekinalp