You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
In Elastica dissipation constant (nu) is defined as per unit length and its unit is kg/(m.s). However, this assumes that rods are uniform. However, in the case of tapered rods dissipation constant should also be scaled with the area. Otherwise for two elements that have same velocity but different mass we apply same dissipation force.
How to fix
Define the dissipation constant as 1/s .
In allocate function, scale the user defined nu with element mass and store it.
Remove multiplication by lengths while computing the dissipation forces and torques.
Hi @armantekinalp some suggestions based on changes in elasticapp.
The name of the parameter must first be changed to damping_rate owing to its nature and units 1/s.
Instead of multiplying in allocate by mass, we should set it as it is there, and for velocity and omega multiply by mass and J / e, respectively, when computing damping forces and torques.
A note should be made in the example cases for damping, where we need to rescale these values to match the old implementation effect.
Describe the bug
In Elastica
dissipation constant (nu)
is defined as per unit length and its unit iskg/(m.s)
. However, this assumes that rods are uniform. However, in the case of tapered rodsdissipation constant
should also be scaled with the area. Otherwise for two elements that have same velocity but different mass we apply same dissipation force.How to fix
1/s
.allocate
function, scale the user definednu
withelement mass
and store it.lengths
while computing the dissipation forces and torques.PyElastica/elastica/rod/cosserat_rod.py
Line 748 in fee87b9
PyElastica/elastica/rod/cosserat_rod.py
Line 843 in fee87b9
The text was updated successfully, but these errors were encountered: