Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 0.2.4 #134

Merged
merged 44 commits into from
Jul 15, 2022
Merged

Update 0.2.4 #134

merged 44 commits into from
Jul 15, 2022

Conversation

skim0119
Copy link
Collaborator

skim0119 and others added 30 commits June 8, 2022 04:28
@skim0119
resolve #106: avoid 0.0 default for rampup
a511e49
@armantekinalp
bugfix:numpy import for rod contact cases
51a5fcf
@armantekinalp
enhancement:adding example cases for contact between rigid cylinder and
8b7cc39 
rod.
@armantekinalp
fix: flag names
fcb45e3
@armantekinalp
fix:capitalize flag names
2e635d8
@armantekinalp
move:post-processing scripts to post_processing.py
2997d10
@armantekinalp
refactor EndPointForcesSinusoidal example and test cases
44a4417
@armantekinalp
Merge pull request #109 from armantekinalp/108_contact_examples_and_f…
d76072e 
…ixes

108 contact examples and fixes
@armantekinalp
enhancement:rod-rod contact compute total velocity
82d1dac
@armantekinalp
hotfix:rod-rod contact examples remove poisson ratio from init
d3f91f2 
This commit removes poisson ratio from the initialization of rods in
rod-rod contact examples. Since initializing poisson ratio is
depreciated.
@armantekinalp
bugfix:remove poisson ratio from initialization
e52ec2b
@armantekinalp
hotfix:rod-rod contact post-processing vis2D flag fix
ce5e12a
@armantekinalp
docs: documentation is added for Endpointforcessinusoidal
312a706
@armantekinalp
update:documentation external_forces.rst
b6fb6f7
@skim0119
Merge pull request #110 from armantekinalp/103_refactor_EndpointForce…
4ecd851 
…sSinusoidal

refactor EndPointForcesSinusoidal example and test cases
@armantekinalp
enhancement:rod-cylinder contact add contact torques on cylinder
6becfdf 
This commit fixes the rod-cylinder contact by adding torques due to the
contact force on cylidner. Previously, we were only dealing with forces
acting on cylinders however any contact force acting away from the cg
will create torque.
@armantekinalp
enhancement:add parallel rod-cylinder contact simulation
8e7614a
@bhosale2
fix: plotting rod radius
96f74fd
@bhosale2
feat: generic inclination angle collision functionality
a241f65
@armantekinalp
fix:remove normal force from rigid body rod contact
a1c7d53
@armantekinalp
Merge pull request #117 from armantekinalp/116_rigid_body_rod_contact
60bae63 
116 rigid body rod contact
@armantekinalp
enhancement:implement cylinder-rod contact friction model
a69def4
@armantekinalp
enhancement:add rod-cylinder contact friction example case.
f53761c
@armantekinalp
fix:connection docs, compatibility table
f318dd8 
Rigid body is not supported for fixed and free joint methods. Correct
the compatibility table.
@skim0119
Merge branch 'master' of https://github.com/GazzolaLab/PyElastica int…
367f516 
…o update-0.2.4
@mstoelzle @skim0119
Fix #128: save_every condition in ExportCallBack (#125)
5b53617 
* Fix bug with `save_every` condition in ExportCallBack
* minimizing any potential delays for saving into storage

Co-authored-by: Seung Hyun Kim <[email protected]>
@skim0119
doc: clarify and refactor step_every, add destructor
536a49e
@armantekinalp
refactor external contact with friction
aa5427a
@armantekinalp
refactor:rigid-body rod contact friction examples
fadc859
@bhosale2
Merge pull request #124 from armantekinalp/121_rigid_body_rod_contact…
03fafd7 
…_friction

121 rigid body rod contact friction
@skim0119 skim0119 added the update Update the codebase label Jul 13, 2022
@skim0119 skim0119 added this to the Version 0.2.4 milestone Jul 13, 2022
@skim0119 skim0119 self-assigned this Jul 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #134 (9e16e3d) into master (8f7037b) will increase coverage by 86.98%.
The diff coverage is 72.18%.

@@             Coverage Diff             @@
##           master     #134       +/-   ##
===========================================
+ Coverage        0   86.98%   +86.98%     
===========================================
  Files           0       40       +40     
  Lines           0     2590     +2590     
  Branches        0      348      +348     
===========================================
+ Hits            0     2253     +2253     
- Misses          0      319      +319     
- Partials        0       18       +18
Impacted Files Coverage Δ
elastica/version.py 0.00% <0.00%> (ø)
elastica/joint.py 22.10% <2.77%> (ø)
elastica/rod/factory_function.py 97.58% <97.95%> (ø)
elastica/callback_functions.py 97.56% <100.00%> (ø)
elastica/external_forces.py 96.22% <100.00%> (ø)
elastica/timestepper/explicit_steppers.py 92.06% <0.00%> (ø)
elastica/_linalg.py 95.65% <0.00%> (ø)
elastica/timestepper/_stepper_interface.py 100.00% <0.00%> (ø)
elastica/wrappers/constraints.py 100.00% <0.00%> (ø)
...ca/reset_functions_for_block_structure/__init__.py 100.00% <0.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7037b...9e16e3d. Read the comment docs.

bhosale2
bhosale2 approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

armantekinalp
armantekinalp approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@skim0119 skim0119 merged commit 112f464 into master Jul 15, 2022
@skim0119 skim0119 deleted the update-0.2.4 branch July 15, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhosale2 bhosale2 bhosale2 approved these changes

@armantekinalp armantekinalp armantekinalp approved these changes

Assignees

@skim0119 skim0119

Labels
update Update the codebase
Projects
None yet
Milestone
Version 0.2.4
Development

Successfully merging this pull request may close these issues.
5 participants
@skim0119 @codecov-commenter @bhosale2 @armantekinalp @mstoelzle