-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry setup for PyElastica (#101) #141
Conversation
Codecov Report
@@ Coverage Diff @@
## update-0.3.0 #141 +/- ##
================================================
+ Coverage 87.30% 87.65% +0.34%
================================================
Files 44 43 -1
Lines 2695 2770 +75
Branches 360 359 -1
================================================
+ Hits 2353 2428 +75
Misses 324 324
Partials 18 18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some question on supported python version. If we want to include 3.9 and 3.10, we should include the CI for windows together with this PR. Or, we can be vague and just say python 3.8+
@bhosale2 Since you are the only one working on this branch, can you rebase and squash those |
00ce48c
to
216784e
Compare
I'll finish the review and merge after I try to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Okay, looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix: wip PR yaml extension refac: publish pypi yaml for poetry refac: ci-sphinx yaml for poetry
update: docs readme for poetry
216784e
to
973eb80
Compare
Fixes #101, a brief checklist:
pyproject.toml/lock
and modifymain.yml
publish-to-pypi.yml
setup.py
,requirements.txt
after confirming complete transfer of information