Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry setup for PyElastica (#101) #141

Merged
merged 18 commits into from
Jul 19, 2022

Conversation

bhosale2
Copy link
Collaborator

@bhosale2 bhosale2 commented Jul 17, 2022

Fixes #101, a brief checklist:

  • Add pyproject.toml/lock and modify main.yml
  • Update publish-to-pypi.yml
  • update docs CI
  • update contrib guidelines to reflect poetry changes
  • update docs readme to reflect poetry changes
  • Remove setup.py, requirements.txt after confirming complete transfer of information

@bhosale2 bhosale2 added the enhancement New feature or request label Jul 17, 2022
@bhosale2 bhosale2 added this to the Version 0.3 milestone Jul 17, 2022
@bhosale2 bhosale2 self-assigned this Jul 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022

Codecov Report

Merging #141 (00ce48c) into update-0.3.0 (735fe00) will increase coverage by 0.34%.
The diff coverage is n/a.

❗ Current head 00ce48c differs from pull request most recent head 216784e. Consider uploading reports for the commit 216784e to get more accurate results

@@               Coverage Diff                @@
##           update-0.3.0     #141      +/-   ##
================================================
+ Coverage         87.30%   87.65%   +0.34%     
================================================
  Files                44       43       -1     
  Lines              2695     2770      +75     
  Branches            360      359       -1     
================================================
+ Hits               2353     2428      +75     
  Misses              324      324              
  Partials             18       18              
Impacted Files Coverage Δ
elastica/boundary_conditions.py 96.42% <ø> (+0.05%) ⬆️
elastica/joint.py 24.91% <ø> (+2.80%) ⬆️
elastica/rod/cosserat_rod.py 100.00% <ø> (ø)
elastica/timestepper/__init__.py 100.00% <ø> (ø)
elastica/rod/knot_theory.py 97.54% <0.00%> (-0.44%) ⬇️
elastica/_rotations.py 100.00% <0.00%> (ø)
elastica/_elastica_numba.py
elastica/timestepper/symplectic_steppers.py 97.97% <0.00%> (+0.02%) ⬆️
elastica/utils.py 98.03% <0.00%> (+0.03%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09babf1...216784e. Read the comment docs.

@bhosale2 bhosale2 linked an issue Jul 18, 2022 that may be closed by this pull request
@bhosale2 bhosale2 changed the title [WIP] Poetry setup for PyElastica (#101) Poetry setup for PyElastica (#101) Jul 18, 2022
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some question on supported python version. If we want to include 3.9 and 3.10, we should include the CI for windows together with this PR. Or, we can be vague and just say python 3.8+

.github/workflows/ci-sphinx.yml Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
@skim0119
Copy link
Collaborator

@bhosale2 Since you are the only one working on this branch, can you rebase and squash those attempts commits?

@skim0119 skim0119 changed the title Poetry setup for PyElastica (#101) [WIP] Poetry setup for PyElastica (#101) Jul 18, 2022
@skim0119
Copy link
Collaborator

I'll finish the review and merge after I try to add 3.6 (trying to find a way to ignore python-version for extra dependencies).

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119
Copy link
Collaborator

Okay, looks like mypy is not the only conflicting dependency. I see coverage and pytest also shifted their python requirement to be 3.7+, and I guess there are more.

Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit bea4153 into GazzolaLab:update-0.3.0 Jul 19, 2022
@skim0119 skim0119 changed the title [WIP] Poetry setup for PyElastica (#101) Poetry setup for PyElastica (#101) Jul 19, 2022
@bhosale2 bhosale2 deleted the 101_poetry_setup branch July 22, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup pyproject (poetry)
4 participants