Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic validation example (#111) #173

Merged
merged 15 commits into from
Aug 17, 2022

Conversation

sy-cui
Copy link
Contributor

@sy-cui sy-cui commented Aug 15, 2022

Fixes #111 by adding a dynamic cantilever example.

The example compares the simulated response of cantilever, initialized by modal oscillations at natural frequencies, to Euler-Bernoulli beam theory. The comparison is made with respect to varying densities.
Dynamic_cantilever_phase_plot

With a given set of parameters, the time-dependent response using the Cosserat model matches the theoretical response in both time and frequency domains (Left: time-dependent cantilever deflection at the tip. Right: corresponding FFT plot).
Dynamic_cantilever_visualization

The example supports modal oscillation up to the first four modes (example using the second mode).

Dynamic_cantilever_mode_2.mp4

@sy-cui sy-cui added enhancement New feature or request prio:low Priority level: low labels Aug 15, 2022
@sy-cui sy-cui added this to the Version 0.3.1 milestone Aug 15, 2022
@sy-cui sy-cui self-assigned this Aug 15, 2022
@bhosale2 bhosale2 linked an issue Aug 15, 2022 that may be closed by this pull request
@skim0119 skim0119 changed the base branch from update-0.3.0 to update-0.3.1 August 15, 2022 19:31
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Some minor changes. Also please update the README.md under the examples folder.

examples/DynamicCantileverCase/dynamic_cantilever.py Outdated Show resolved Hide resolved
examples/DynamicCantileverCase/dynamic_cantilever.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #173 (48108b0) into update-0.3.1 (f9b891f) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           update-0.3.1     #173   +/-   ##
=============================================
  Coverage         87.60%   87.60%           
=============================================
  Files                43       43           
  Lines              2815     2815           
  Branches            367      367           
=============================================
  Hits               2466     2466           
  Misses              328      328           
  Partials             21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sy-cui sy-cui requested a review from armantekinalp August 16, 2022 20:53
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes. @bhosale2 please look after these changes are implemented

examples/DynamicCantileverCase/dynamic_cantilever.py Outdated Show resolved Hide resolved
examples/DynamicCantileverCase/dynamic_cantilever.py Outdated Show resolved Hide resolved
examples/DynamicCantileverCase/dynamic_cantilever.py Outdated Show resolved Hide resolved
examples/DynamicCantileverCase/dynamic_cantilever.py Outdated Show resolved Hide resolved
examples/DynamicCantileverCase/dynamic_cantilever.py Outdated Show resolved Hide resolved
examples/DynamicCantileverCase/dynamic_cantilever.py Outdated Show resolved Hide resolved
examples/DynamicCantileverCase/dynamic_cantilever.py Outdated Show resolved Hide resolved
@sy-cui sy-cui requested a review from armantekinalp August 17, 2022 14:49
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff.

examples/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @armantekinalp you can finish up with any minor stuff if needed.

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work. You can merge the code after CI build

@armantekinalp armantekinalp merged commit 1591f21 into GazzolaLab:update-0.3.1 Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:low Priority level: low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A minimal dynamic validation case for PyElastica
4 participants