Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#152) Windows CI fix #192

Merged
merged 3 commits into from
Aug 21, 2022
Merged

(#152) Windows CI fix #192

merged 3 commits into from
Aug 21, 2022

Conversation

bhosale2
Copy link
Collaborator

Fixes #152. Fixed failing CI on Windows by refactoring file open calls, replaced by safe with context manager.

@bhosale2 bhosale2 added invalid This doesn't seem right prio:low Priority level: low labels Aug 21, 2022
@bhosale2 bhosale2 added this to the Version 0.3.1 milestone Aug 21, 2022
@bhosale2 bhosale2 requested a review from skim0119 August 21, 2022 21:43
@bhosale2 bhosale2 self-assigned this Aug 21, 2022
@bhosale2 bhosale2 removed the request for review from armantekinalp August 21, 2022 21:43
@bhosale2 bhosale2 linked an issue Aug 21, 2022 that may be closed by this pull request
CI failing for windows OS #152
Closed
@bhosale2 bhosale2 added prio:medium Priority level: medium and removed prio:low Priority level: low labels Aug 21, 2022
skim0119
skim0119 approved these changes Aug 21, 2022
View reviewed changes
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit 435ae35 into GazzolaLab:update-0.3.1 Aug 21, 2022
@bhosale2 bhosale2 deleted the 152_windows_ci_fix branch August 21, 2022 23:02
@bhosale2 bhosale2 mentioned this pull request Aug 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skim0119 skim0119 skim0119 approved these changes

Assignees

@bhosale2 bhosale2

Labels
invalid This doesn't seem right prio:medium Priority level: medium
Projects
None yet
Milestone
Version 0.3.1
Development

Successfully merging this pull request may close these issues.

CI failing for windows OS
2 participants
@bhosale2 @skim0119