Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix main yml windows python version #206

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Bug fix main yml windows python version #206

merged 3 commits into from
Oct 21, 2022

Conversation

armantekinalp
Copy link
Contributor

  • Removes Windows build from CI, due to the bug in CI system.
  • Removes Python version 3.7 builds, since some of the dependencies are not supporting 3.7 anymore.

We could activate windows builds in future.

@armantekinalp
bugfix:Remove windows and python 3.7 from CI
db0bfa5 
CI is failing for windows builds. Also Python 3.7 is not supported by
some of the dependency versions.
@armantekinalp armantekinalp added the bug Something isn't working label Oct 19, 2022
@armantekinalp armantekinalp self-assigned this Oct 19, 2022
@armantekinalp armantekinalp mentioned this pull request Oct 19, 2022
Closed
@skim0119
Copy link
Collaborator

  • Removes Windows build from CI, due to the bug in CI system.
  • Removes Python version 3.7 builds, since some of the dependencies are not supporting 3.7 anymore.

Which dependencies? If we are dropping support for 3.7, we need to edit pyproject as well.

We could activate windows builds in future.

Can we make an issue for this?

@armantekinalp armantekinalp mentioned this pull request Oct 19, 2022
Open
@armantekinalp
Copy link
Contributor Author

New Numba version 0.56.3 is failing. I updated pyproject and poetry. Also I created a new issue for windows CI.

@bhosale2 bhosale2 added the prio:high Priority level: high label Oct 21, 2022
bhosale2
bhosale2 approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhosale2 bhosale2 merged commit 49d6507 into GazzolaLab:update-0.3.1 Oct 21, 2022
@bhosale2 bhosale2 deleted the bugfix_main_yml_windows_python_version branch October 21, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhosale2 bhosale2 bhosale2 approved these changes

@skim0119 skim0119 Awaiting requested review from skim0119

Assignees

@armantekinalp armantekinalp

Labels
bug Something isn't working prio:high Priority level: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armantekinalp @skim0119 @bhosale2