(#119) Wildcard imports removed

[AsadNizami]

Fix for #193. I have tested all the examples. Sorry for working on the issues before it's assigned to me.

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (bb0d16f) 87.53% compared to head (530387b) 87.45%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@               Coverage Diff                @@
##           update-0.3.1     #238      +/-   ##
================================================
- Coverage         87.53%   87.45%   -0.09%     
================================================
  Files                44       41       -3     
  Lines              2817     2798      -19     
  Branches            320      320              
================================================
- Hits               2466     2447      -19     
  Misses              330      330              
  Partials             21       21              

Impacted Files	Coverage Δ
elastica/boundary_conditions.py	94.97% <ø> (-0.03%)	⬇️
elastica/callback_functions.py	97.53% <ø> (-0.04%)	⬇️
elastica/dissipation.py	95.45% <ø> (-0.11%)	⬇️
elastica/external_forces.py	96.36% <ø> (-0.04%)	⬇️
elastica/interaction.py	89.06% <ø> (-0.06%)	⬇️
elastica/joint.py	24.91% <ø> (-0.25%)	⬇️
elastica/modules/__init__.py	100.00% <ø> (ø)
elastica/restart.py	80.00% <ø> (-0.65%)	⬇️
elastica/rigidbody/cylinder.py	100.00% <ø> (ø)
elastica/rigidbody/sphere.py	100.00% <ø> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bhosale2]

LGTM.

[bhosale2]

@AsadNizami so @armantekinalp and I noticed that there are a lot of wildcard imports scattered throughout the library in files under elastica folder. There the wildcard imports only import the parts defined in the __all__ keywords of individual files. Can you please remove the __all__ keywords, replace wildcard with absolute imports, and test in the end, as a part of this PR? Thanks!

[AsadNizami]

Sure, I'll get it done!

[AsadNizami]

Please review.
Ran the tests, looks fine

[bhosale2]

Hi @AsadNizami I had 2 comments:

1. Please check the formatting failing tests and fix them.
2. I saw that you got rid of the __all__ keywords from submodules. However, if you see the __init__.py in elastica, the wildcard imports now import everything from individual submodules, which is not required and is also a bit inefficient. Can you please remove those wildcards, and specifically import the functionalities we need there from the submodules? If you have any questions about this let me know.

[AsadNizami]

2. specifically import the functionalities we need there from the submodules?

This includes all the classes mentioned in the __init__ of all submodules and those of other files present in the same directory as elastica/__init__.py, right?

[bhosale2]

@AsadNizami Yes, the idea is wherever possible wildcard imports should be replaced while making sure existing example scripts and paths don't break.

[AsadNizami]

Pls review!

[AsadNizami]

Pls review.

[bhosale2]

LGTM. @armantekinalp this one is all yours.

[armantekinalp]

LGTM. Thanks