Task 2: Unit test for specific functions part 3 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rahul-JOON a small note, if you are still making changes to a PR after opening it, please either mark it as WIP or draft unless final to review. |
bhosale2
added
enhancement
|
Understood and noted, Thanks @bhosale2 |
armantekinalp
approved these changes
Jun 2, 2023
Co-authored-by: Arman Tekinalp <[email protected]>
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## update-0.3.2 #261 +/- ##
================================================
+ Coverage 91.52% 93.87% +2.34%
================================================
Files 43 43
Lines 2938 2938
Branches 341 341
================================================
+ Hits 2689 2758 +69
+ Misses 217 144 -73
- Partials 32 36 +4
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the test case for the functions - _calculate_contact_forces_self_rod & _calculate_contact_forces_rod_rod as mentioned in #99.
Because the codebase is not broken, all of the test cases are currently passing.