-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface subclass: plane, and tests #293
Surface subclass: plane, and tests #293
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## update-0.3.2 #293 +/- ##
================================================
- Coverage 93.71% 93.02% -0.70%
================================================
Files 48 50 +2
Lines 3055 3340 +285
Branches 354 392 +38
================================================
+ Hits 2863 3107 +244
- Misses 155 181 +26
- Partials 37 52 +15
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Yashraj Bhosale <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Seung Hyun Kim <[email protected]>
Co-authored-by: Seung Hyun Kim <[email protected]>
Co-authored-by: Seung Hyun Kim <[email protected]>
Third contact module PR mentioned in Issue
This PR includes:
InteractionPlane
,AnistropicFrictionalPlane
andInteractionPlaneRigidBody
in interaction.