Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface subclass: plane, and tests #293

Merged
merged 8 commits into from
Aug 24, 2023

Conversation

Ali-7800
Copy link
Collaborator

Third contact module PR mentioned in Issue

This PR includes:

  • New plane surface subclass, will be used to define rod-plane and cylinder-plane contact classes that will replace InteractionPlane, AnistropicFrictionalPlane and InteractionPlaneRigidBody in interaction.
  • Plane object initialization test.

@Ali-7800 Ali-7800 added enhancement New feature or request prio:high Priority level: high labels Aug 21, 2023
@Ali-7800 Ali-7800 added this to the Version 0.3.2 milestone Aug 21, 2023
@Ali-7800 Ali-7800 self-assigned this Aug 21, 2023
@Ali-7800 Ali-7800 requested a review from skim0119 as a code owner August 21, 2023 23:00
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Patch coverage: 85.01% and project coverage change: -0.70% ⚠️

Comparison is base (fd62afa) 93.71% compared to head (44ffc97) 93.02%.
Report is 20 commits behind head on update-0.3.2.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@               Coverage Diff                @@
##           update-0.3.2     #293      +/-   ##
================================================
- Coverage         93.71%   93.02%   -0.70%     
================================================
  Files                48       50       +2     
  Lines              3055     3340     +285     
  Branches            354      392      +38     
================================================
+ Hits               2863     3107     +244     
- Misses              155      181      +26     
- Partials             37       52      +15     
Files Changed Coverage Δ
elastica/surface/__init__.py 100.00% <ø> (ø)
elastica/contact_forces.py 81.96% <81.81%> (-5.54%) ⬇️
elastica/contact_utils.py 89.21% <89.21%> (ø)
elastica/joint.py 85.85% <100.00%> (+0.09%) ⬆️
elastica/modules/contact.py 100.00% <100.00%> (+4.76%) ⬆️
elastica/surface/plane.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

elastica/surface/plane.py Show resolved Hide resolved
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elastica/surface/plane.py Outdated Show resolved Hide resolved
elastica/surface/plane.py Outdated Show resolved Hide resolved
tests/test_surface/test_plane.py Outdated Show resolved Hide resolved
@Ali-7800 Ali-7800 requested a review from bhosale2 August 23, 2023 01:41
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elastica/surface/plane.py Outdated Show resolved Hide resolved
elastica/surface/plane.py Outdated Show resolved Hide resolved
elastica/surface/plane.py Outdated Show resolved Hide resolved
Ali-7800 and others added 3 commits August 24, 2023 12:05
@armantekinalp armantekinalp merged commit 23cc6ed into GazzolaLab:update-0.3.2 Aug 24, 2023
@Ali-7800 Ali-7800 deleted the 113_dev_contact branch October 20, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:high Priority level: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants