-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
266 rod and sphere contact temp #301
266 rod and sphere contact temp #301
Conversation
…Contact Rod sphere contact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RodSphereContact import was missing in the init.py I fixed it just update your branch.
…d_and_Sphere_Contact_temp
…in rod-cylinder and rod-sphere contact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One comment for removing args
and kwargs
for this module.
@skim0119 but user cannot control those |
I agree that we don't need, but I was thinking that its a feature that doesn't need to be removed. Maybe lets remove it, merge PR as it is, but consider removing args and kwargs in other modules in the future? Its probably better to pass parameters more explicitly. |
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM three suggestions. You can directly commit
Co-authored-by: Arman Tekinalp <[email protected]>
Co-authored-by: Arman Tekinalp <[email protected]>
Co-authored-by: Arman Tekinalp <[email protected]>
Finishing requested changes in #298