Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

266 rod and sphere contact temp #301

Merged

Conversation

Ali-7800
Copy link
Collaborator

@Ali-7800 Ali-7800 commented Oct 2, 2023

Finishing requested changes in #298

@Ali-7800 Ali-7800 added enhancement New feature or request prio:medium Priority level: medium labels Oct 2, 2023
@Ali-7800 Ali-7800 self-assigned this Oct 2, 2023
@Ali-7800 Ali-7800 requested a review from bhosale2 as a code owner October 2, 2023 22:16
@Ali-7800 Ali-7800 removed the request for review from bhosale2 October 2, 2023 22:38
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RodSphereContact import was missing in the init.py I fixed it just update your branch.

@armantekinalp armantekinalp self-requested a review October 3, 2023 14:47
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment for removing args and kwargs for this module.

elastica/contact_forces.py Outdated Show resolved Hide resolved
@armantekinalp
Copy link
Contributor

@skim0119 but user cannot control those *args and *kwargs, they are different then the ones we use while constructing the class . So I don't think we need. We can pass time explicitly? What do you think

@skim0119
Copy link
Collaborator

skim0119 commented Oct 7, 2023

@skim0119 but user cannot control those *args and *kwargs, they are different then the ones we use while constructing the class . So I don't think we need. We can pass time explicitly? What do you think

I agree that we don't need, but I was thinking that its a feature that doesn't need to be removed. Maybe lets remove it, merge PR as it is, but consider removing args and kwargs in other modules in the future? Its probably better to pass parameters more explicitly.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
elastica/contact_utils.py 94.16% <100.00%> (+4.95%) ⬆️
elastica/modules/contact.py 100.00% <100.00%> (ø)
elastica/contact_forces.py 80.08% <76.92%> (-1.89%) ⬇️

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM three suggestions. You can directly commit

elastica/contact_forces.py Outdated Show resolved Hide resolved
elastica/contact_forces.py Outdated Show resolved Hide resolved
elastica/contact_forces.py Outdated Show resolved Hide resolved
Ali-7800 and others added 2 commits October 10, 2023 15:33
@armantekinalp armantekinalp merged commit ae9058e into GazzolaLab:update-0.3.2 Oct 10, 2023
@Ali-7800 Ali-7800 deleted the 266_Rod_and_Sphere_Contact_temp branch October 13, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:medium Priority level: medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants