Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cylinder-plane contact class and tests #328

Merged
merged 8 commits into from
Feb 13, 2024

Conversation

Ali-7800
Copy link
Collaborator

@Ali-7800 Ali-7800 commented Feb 5, 2024

7th contact module PR mentioned in Issue
This PR includes:

  • Added CylinderPlaneContact class.
  • Refactored apply_normal_force_numba_rigid_body to _calculate_contact_forces_cylinder_plane.
  • Added tests for CylinderPlaneContact and fixed some typos.

@Ali-7800 Ali-7800 added enhancement New feature or request prio:medium Priority level: medium labels Feb 5, 2024
@Ali-7800 Ali-7800 added this to the Version 0.3.2 milestone Feb 5, 2024
@Ali-7800 Ali-7800 self-assigned this Feb 5, 2024
@Ali-7800 Ali-7800 removed the request for review from bhosale2 February 5, 2024 22:46
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f6b33d5) 93.46% compared to head (b1fa5d4) 94.01%.

Files Patch % Lines
elastica/contact_forces.py 90.90% 0 Missing and 1 partial ⚠️
elastica/interaction.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           update-0.3.2     #328      +/-   ##
================================================
+ Coverage         93.46%   94.01%   +0.54%     
================================================
  Files                51       51              
  Lines              3183     3172      -11     
  Branches            348      347       -1     
================================================
+ Hits               2975     2982       +7     
+ Misses              158      140      -18     
  Partials             50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change

tests/test_interaction.py Show resolved Hide resolved
Copy link
Contributor

@ilianasiriziba ilianasiriziba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armantekinalp armantekinalp merged commit 1bf7fca into GazzolaLab:update-0.3.2 Feb 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:medium Priority level: medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants