-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cylinder-plane contact class and tests #328
Cylinder-plane contact class and tests #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## update-0.3.2 #328 +/- ##
================================================
+ Coverage 93.46% 94.01% +0.54%
================================================
Files 51 51
Lines 3183 3172 -11
Branches 348 347 -1
================================================
+ Hits 2975 2982 +7
+ Misses 158 140 -18
Partials 50 50 ☔ View full report in Codecov by Sentry. |
bypass deprecation warning/error messages https://coverage.readthedocs.io/en/latest/excluding.html#excluding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7th contact module PR mentioned in Issue
This PR includes:
CylinderPlaneContact
class.apply_normal_force_numba_rigid_body
to_calculate_contact_forces_cylinder_plane.
CylinderPlaneContact
and fixed some typos.