-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update on constraint module; Add generalized constraint class #56
Conversation
b0d8b70
to
c0576ce
Compare
c0576ce
to
88b395a
Compare
Codecov Report
@@ Coverage Diff @@
## update-0.2.2 #56 +/- ##
================================================
+ Coverage 81.26% 81.70% +0.43%
================================================
Files 40 40
Lines 2552 2645 +93
Branches 357 372 +15
================================================
+ Hits 2074 2161 +87
- Misses 453 458 +5
- Partials 25 26 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything looks good. I have some questions, could you please address them @skim0119
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small documentation comment.
3d89597
to
d837a80
Compare
d837a80
to
c629a78
Compare
Dev Note
Related to #54 , the current
constraint
component does not pass the indices to the class methods. As a result, it is difficult to implement constraint or boundary conditions at the middle of the rod. I talked to @tp5uiuc, and this is definitely not intended behavior.To fix the issue and improve future functionality, I'm exposing
system(rod)
,position indices
, anddirector indices
to the constraining/BC class. This should make BC implementation more flexible.In addition, I refactored @nmnaughton 's implementation on more general BC:
FixedRodBC
andFixedNodeBC
(#54). I added an example script on how to use new constraintFixedConstraint
. The PR also includes test codes.How to use
FixedConstraint
Update
ConstraintBase
abstract class is added to provide template for all constraint classes.FreeRod
should not get errors, but a deprecation warning should appear.system
,position_indices
, anddirector_indices
are added.FreeRod
andOneEndFixedRod
are refactored toFreeBC
andOneEndFixedBC
. I made an alias and deprecation note so that people have time to notice the change and convert their code.FixedConstraint
with documentation.FixedConstraint
is added and tested.ConstraintBase
class is added and tested.resolve #55