Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting getting started guide from website to docs page #58

Merged

Conversation

nmnaughton
Copy link
Collaborator

I ported over the getting started guide from the website to the docs page per #49. It uses the new myst_parser version of the docs which doesn't look like it has been merged with master so I think this is the best branch to PR too.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (doc_patch@f709d12). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             doc_patch      #58   +/-   ##
============================================
  Coverage             ?   81.69%           
============================================
  Files                ?       40           
  Lines                ?     2644           
  Branches             ?      372           
============================================
  Hits                 ?     2160           
  Misses               ?      458           
  Partials             ?       26           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f709d12...91267e2. Read the comment docs.

@nmnaughton nmnaughton self-assigned this Feb 13, 2022
@nmnaughton nmnaughton added the documentation Improvements or additions to documentation label Feb 13, 2022
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@skim0119 skim0119 merged commit 0b10955 into GazzolaLab:doc_patch Feb 13, 2022
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants