Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch: Rod constructor warning messages #71

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Patch: Rod constructor warning messages #71

merged 5 commits into from
Apr 28, 2022

Conversation

skim0119
Copy link
Collaborator

@skim0119 skim0119 commented Apr 10, 2022 •
edited
Loading

  • The logging level of some messages is lowered (warning->info) in order to avoid unnecessary logging.
    • Technically the warning should be given when both poisson_ratio and shear_modulus are given. In this case, a warning should say poisson_ratio will be ignored.
    • In any other case, we just need to log what happened. I don't think it is necessary to throw a warning.
  • Refactored the name: too many kwargs lowers readability.
  • Refactored allocate

@skim0119 skim0119 added the enhancement New feature or request label Apr 10, 2022
@skim0119 skim0119 added this to the Version 0.2.3 milestone Apr 10, 2022
@skim0119 skim0119 requested a review from armantekinalp April 10, 2022 05:56
@skim0119 skim0119 self-assigned this Apr 10, 2022
@skim0119 skim0119 changed the title Patch: Rod constructor Patch: Rod constructor warning messages Apr 10, 2022
@skim0119
update: moduli assignment for Cosserat Rod
a06ac63 
The logging level of some messages are lowered (warning->info) in order
to avoid unnecessary logging.
@skim0119 skim0119 force-pushed the patch-rod-constructor branch from 209d3c1 to a06ac63 Compare April 10, 2022 05:57
@skim0119 skim0119 force-pushed the patch-rod-constructor branch from e38e936 to 6b9dc8c Compare April 10, 2022 18:38
armantekinalp
armantekinalp approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM lets merge

@skim0119 skim0119 merged commit 86e1d33 into GazzolaLab:update-0.2.3 Apr 28, 2022
@skim0119 skim0119 deleted the patch-rod-constructor branch April 28, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

Assignees

@skim0119 skim0119

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 0.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@skim0119 @armantekinalp