🐛 Reviews group can be None (#1185)

GemeenteUtrecht · Feb 23, 2024 · eafccf7 · eafccf7
1 parent 70098fc
commit eafccf7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/backend/src/zac/contrib/objects/kownsl/camunda.py b/backend/src/zac/contrib/objects/kownsl/camunda.py
@@ -370,7 +370,7 @@ def validate(self, data):
             for given_review in review_request.get_reviews():
                 already_reviewed.append(
                     given_review.group["name"]
-                    if given_review.group.get("name")
+                    if given_review.group and given_review.group.get("name")
                     else given_review.author["username"]
                 )
             assignees = []
@@ -479,7 +479,7 @@ def get_review_request_from_task(task: Task) -> Optional[ReviewRequest]:
             remove_these_users.append(
                 (
                     given_review.group["name"]
-                    if given_review.group.get("name")
+                    if given_review.group and given_review.group.get("name")
                     else given_review.author["username"]
                 )
             )

diff --git a/backend/src/zac/contrib/objects/kownsl/data.py b/backend/src/zac/contrib/objects/kownsl/data.py
@@ -203,7 +203,7 @@ def get_open_reviews(self) -> List[OpenReview]:
             # remove those who have already reviewed
             for review in self.get_reviews():
                 # if the reviewer is a group remove the group and...
-                if name := review.group.get("name"):
+                if review.group and (name := review.group.get("name")):
                     user_deadlines.pop(f"{AssigneeTypeChoices.group}:{name}", None)
 
                 # ... the user if the reviewer is a user

diff --git a/backend/src/zac/contrib/objects/kownsl/permissions.py b/backend/src/zac/contrib/objects/kownsl/permissions.py
@@ -139,7 +139,7 @@ def has_object_permission(self, request, view, obj):
                 if assignee_is_user:
                     continue
 
-                if assignee.name == review.group["name"]:
+                if assignee.name == review.group.get("name"):
                     self.message = self._message.format(
                         assignee=assignee.name, identificatie=zaak.identificatie
                     )