109 my plot diff

[audreyyeoCH]

closes #109

[audreyyeoCH]

Hi @danielinteractive, there's probably some design questions here on how we want the plot to look, could you review and share what do you think please ? The colours chosen are from a colour blind friendly template

[audreyyeoCH]

Hi @danielinteractive, I'm about to make .svg files for expect_doppelganger but wanted to check what you think of these plots. I am referring to the crmPack repo to do this... first time!

[danielinteractive]

Hi @danielinteractive, I'm about to make .svg files for expect_doppelganger but wanted to check what you think of these plots. I am referring to the crmPack repo to do this... first time!

Hi @audreyyeoCH , ok cool, can you copy/paste screenshots of the plots here? Then it saves me time to install and run the branch package version

[audreyyeoCH]

Awesome, thanks for checking them out, here they are:

parX <- c(1, 52) # prior  parameters of experimental arm
parY <- c(5.5, 20.5) # prior  parameters of control or SOC
plotBetaDiff( # plot1
  parY = parY,
  parX = parX,
  Go_cut = 0.3,
  Stop_cut = 0.1, # below a difference of 10%, is an unsuccessful trial
  shade = TRUE,
  note = TRUE
)

With uniform prior

plotBetaDiff( # plot2
parY = c(1, 1), # prior  parameters for experimental arm
  parX = c(1, 1), # prior parameters for control or SOC arm
  Go_cut = 0.3,
  Stop_cut = 0.1, # below a difference of 10%, is an unsuccessful trial
  shade = TRUE,
  note = TRUE
)

[audreyyeoCH]

ok I see we have to fix the P(S)there....

[danielinteractive]

ok I see we have to fix the P(S)there....

Thanks they look nice, yes I would also think P(Stop) would be better

[github-actions]

Unit Tests Summary

    1 files     15 suites   1m 52s ⏱️
  118 tests   117 ✅ 0 💤 0 ❌ 1 🔥
1 249 runs  1 248 ✅ 0 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit 4b66fc5.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
ocPredprobDist	💔	$50.74$	$+1.02$	$0$	$0$	$0$	$0$
plotBetaDiff	👶		$+0.05$	$+1$	$0$	$0$	$+1$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
plotBetaDiff	👶		$+0.05$	plotBetaDiff_works_as_expected

Results for commit 214db64

♻️ This comment has been updated with latest results.