Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

115 add website content #118

Merged
merged 53 commits into from
Sep 9, 2024
Merged

115 add website content #118

merged 53 commits into from
Sep 9, 2024

Conversation

audreyyeoCH
Copy link
Collaborator

closes #103

Copy link
Contributor

github-actions bot commented Aug 13, 2024

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------
R/betadiff.R                59       0  100.00%
R/boundsPostprob.R          31      31  0.00%    32-71
R/boundsPredprob.R          28      28  0.00%    36-73
R/dbetabinom.R              57       3  94.74%   32, 62, 129
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R              99       4  95.96%   239-242
R/ocPostprobDist.R         109       0  100.00%
R/ocPredprob.R             182       4  97.80%   285-288
R/ocPredprobDist.R         235       3  98.72%   346-348
R/ocRctPostprobDist.R      154       4  97.40%   236-239
R/ocRctPredprobDist.R      283      55  80.57%   207-222, 225-240, 373-376, 403-421
R/plotBeta.R               103      90  12.62%   60-167
R/plotBounds.R              52      52  0.00%    33-90
R/plotDecision.R            79      79  0.00%    16-136
R/plotOc.R                  15      15  0.00%    16-36
R/postprob.R                29       1  96.55%   99
R/postprobDist.R            78       1  98.72%   208
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumbetadiff.R             63      63  0.00%    24-101
R/sumTable.R                20      20  0.00%    25-48
TOTAL                     2152     766  64.41%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 85ad0aa

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Unit Tests Summary

    1 files     13 suites   11m 37s ⏱️
  111 tests   111 ✅ 0 💤 0 ❌
1 224 runs  1 224 ✅ 0 💤 0 ❌

Results for commit 85ad0aa.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ocPostprob 💚 $52.85$ $-1.50$ $0$ $0$ $0$ $0$
ocPredprobDist 💔 $445.42$ $+4.68$ $0$ $0$ $0$ $0$
ocRctPredprobDist 💚 $174.62$ $-2.94$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ocPredprobDist 💔 $106.02$ $+2.07$ ocPredprobDist_gives_correct_result_and_list_when_relativeDelta_FALSE
ocPredprobDist 💔 $165.35$ $+2.43$ ocPredprobDist_gives_higher_PrFutility_with_more_futility_looks
ocRctPredprobDist 💚 $69.87$ $-1.43$ ocRctPredprobDist_gives_higher_PrEfficacy_with_increased_pE
ocRctPredprobDist 💚 $69.50$ $-1.08$ ocRctPredprobDist_gives_higher_PrFutility_with_decreased_pE

Results for commit 1401b97

♻️ This comment has been updated with latest results.

@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive the checks cleared, could you kindly review ? Thanks!

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @audreyyeoCH for driving this forward!

DESCRIPTION Outdated Show resolved Hide resolved
README.rmd Outdated Show resolved Hide resolved
README.rmd Outdated Show resolved Hide resolved
README.rmd Outdated Show resolved Hide resolved
README.rmd Show resolved Hide resolved
inst/WORDLIST Outdated Show resolved Hide resolved
README.rmd Show resolved Hide resolved
vignettes/introduction.Rmd Show resolved Hide resolved
@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive are you able to review again please ? Hopefully thereafter incorporate Isaac's changes and CMD checks will be faster, thanks again !

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audreyyeoCH , please have another look, a few things still need to be corrected

README.rmd Outdated Show resolved Hide resolved
README.rmd Outdated Show resolved Hide resolved
README.rmd Outdated Show resolved Hide resolved
@danielinteractive danielinteractive self-requested a review September 9, 2024 02:12
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @audreyyeoCH !

@audreyyeoCH audreyyeoCH merged commit c9c1440 into main Sep 9, 2024
24 checks passed
@audreyyeoCH audreyyeoCH deleted the 115_make_website_live branch September 9, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

103_add_web_content
2 participants