Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16: clean postprobDist #20

Merged
merged 118 commits into from
Nov 21, 2023
Merged

16: clean postprobDist #20

merged 118 commits into from
Nov 21, 2023

Conversation

audreyyeoCH
Copy link
Collaborator

closes #16

audreyyeoCH and others added 30 commits August 14, 2023 17:53
@audreyyeoCH
cleaning up dbetabinom
50ef5b1
@audreyyeoCH
removed rounding, not needed
4342b5a
@audreyyeoCH
rmarkdown language and assert for dbetabinom
b095ae6
@audreyyeoCH
changed x and m to number instead of numeric
889e97d
@audreyyeoCH
test
2eafdc5
@audreyyeoCH
pbetaMix function and test
9dc428b
@audreyyeoCH
added new tests and changed documentation
dd1d8c4
@audreyyeoCH
upper case for test_that comments and more tests for qbeta
6d7f478
@audreyyeoCH
Merge branch 'main' into 9_pbeta
d520ff0
@audreyyeoCH
test_thats for pbetaMix and qbetaMix
0b361e3
@audreyyeoCH
tidy syntax and last checks
8b20f72
@audreyyeoCH
tidy syntax and last checks
b0c2218
@audreyyeoCH
Merge remote-tracking branch 'origin/9_pbeta' into 9_pbeta
9f53521
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
5384c3d 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@dependabot-preview
[skip actions] Roxygen Man Pages Auto Update
f5403fa
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
0dd2bab 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
ca0236f 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
9cf54d0 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
2eb3bd2 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
c08435f 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
e36facd 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
f45d2f0 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update examples/pbetaMix.R
0505982 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH
p and q inputs
469ed6e
@audreyyeoCH
q,p changes
1abea50
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
b7b523c 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@dependabot-preview
[skip actions] Roxygen Man Pages Auto Update
34a663b
@audreyyeoCH
documentation to reflect p and q changes
f384100
@audreyyeoCH
Merge remote-tracking branch 'origin/9_pbeta' into 9_pbeta
f0d5d00
@audreyyeoCH
amending qt
b9e50b2
@danielinteractive
Copy link
Collaborator

So from

phase1b/R/postprobDist.R

Line 163 in a199f63

if (is.vector(parE)) {
I would understand that we only transpose when parE is a vector. If it is a matrix, we don't transpose. Or not?

@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented Nov 16, 2023 •
edited
Loading

So from

phase1b/R/postprobDist.R

Line 163 in a199f63

if (is.vector(parE)) {

I would understand that we only transpose when parE is a vector. If it is a matrix, we don't transpose. Or not?

Screenshot 2023-11-16 at 16 04 28 ahh, TRUE...ok! Thanks :)

danielinteractive
danielinteractive reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audreyyeoCH , let's first finish this PR, afterwards we can come back to other PR

R/postprobDist.R Outdated Show resolved Hide resolved
R/postprobDist.R Outdated Show resolved Hide resolved
R/postprobDist.R Outdated Show resolved Hide resolved
R/postprobDist.R Outdated Show resolved Hide resolved
R/postprobDist.R Outdated Show resolved Hide resolved
examples/postprobDist.R Outdated Show resolved Hide resolved
examples/postprobDist.R Outdated Show resolved Hide resolved
examples/postprobDist.R Outdated Show resolved Hide resolved
examples/postprobDist.R Show resolved Hide resolved
inst/WORDLIST Outdated Show resolved Hide resolved
audreyyeoCH and others added 14 commits November 17, 2023 14:52
@audreyyeoCH @danielinteractive
Update R/postprobDist.R
76a0258 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/postprobDist.R
8fbb597 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update examples/postprobDist.R
ad89a23 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update examples/postprobDist.R
6cf8743 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH
clean
0ab1ead
@audreyyeoCH
clean
038c6a6
@audreyyeoCH @danielinteractive
Update R/postprobDist.R
933d043 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update tests/testthat/test-postprobDist.R
90b4d7f 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update tests/testthat/test-postprobDist.R
236617b 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update examples/postprobDist.R
dc8d311 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update tests/testthat/test-postprobDist.R
2a4c3b3 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update tests/testthat/test-postprobDist.R
07fd3b1 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update tests/testthat/test-postprobDist.R
6ad8f58 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update tests/testthat/test-postprobDist.R
89c5d66 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH
Copy link
Collaborator Author

Some of the error messages are high and low caps, and the test seems to be case sensitive

@audreyyeoCH audreyyeoCH marked this pull request as draft November 18, 2023 07:39
@danielinteractive danielinteractive marked this pull request as ready for review November 20, 2023 08:41
@audreyyeoCH audreyyeoCH merged commit a3c3d34 into main Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@audreyyeoCH @danielinteractive