25 Design Doc for predprobDist.R
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to break the function into several issues, currently PR in draft mode |
audreyyeoCH
changed the title
audreyyeoCH
changed the title
predprobDist.R
|
Hi @danielinteractive, I have managed to create two helper functions. Could you have a look ? I thought to start an issue for one of the helper functions, and start doing the test file as well for it |
There was a problem hiding this comment.
Thanks @audreyyeoCH yeah let's first get this PR finished and merged, afterwards can start new issues / PRs for the actual changes in the package then i.e. adding and using the new helper functions.
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
danielinteractive
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.