41_h_get_decisionDist.R clean

[audreyyeoCH]

closes #41

[danielinteractive]

Thanks @audreyyeoCH , please see below - next step please add the tests.
btw - looking at https://github.com/Genentech/phase1b/blob/main/tests/testthat/test-ocPostprob.R#L32 please also add an expectation for the all_sizes list element there and for the new tests here

[github-actions]

🧪 Test coverage: 31.72%

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ------------
R/betadiff.R                59       0  100.00%
R/boundsPostprob.R          31      31  0.00%    35-74
R/boundsPredprob.R          28      28  0.00%    40-77
R/dbetabinom.R              60       3  95.00%   32, 62, 132
R/helpers.R                 17      15  11.76%   10-57
R/oc2.R                    162     162  0.00%    99-332
R/oc3.R                    146     146  0.00%    97-314
R/ocPostprob.R              95       4  95.79%   232-235
R/ocPostprobDist.R         119      69  42.02%   141-215
R/ocPredprob.R              53      53  0.00%    68-138
R/ocPredprobDist.R          63      63  0.00%    70-149
R/ocRctPostprobDist.R      107     107  0.00%    81-224
R/ocRctPredprobDist.R      104     104  0.00%    86-227
R/plotBeta.R               107     107  0.00%    16-174
R/plotBounds.R              52      52  0.00%    37-94
R/plotDecision.R            79      79  0.00%    19-139
R/plotOc.R                  15      15  0.00%    16-36
R/postprob.R                29       1  96.55%   102
R/postprobDist.R            78       1  98.72%   212
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       3  97.86%   271-272, 275
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumbetadiff.R             63      63  0.00%    27-104
R/sumTable.R                20      20  0.00%    25-48
TOTAL                     1655    1130  31.72%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/ocPostprob.R           +2       0  +0.09%
R/ocPostprobDist.R      +58      +8  +42.02%
R/postprobDist.R          0      -2  +2.56%
TOTAL                   +60      +6  +2.19%

Results for commit: dee7c07

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files    9 suites   1m 29s ⏱️
 83 tests  83 ✅ 0 💤 0 ❌
123 runs  123 ✅ 0 💤 0 ❌

Results for commit dee7c07.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
ocPostprob	💔	$57.07$	$+17.38$	$+1$	$0$	$0$	$0$
ocPostprobDist	👶		$+0.11$	$+9$	$0$	$0$	$0$
predprobDist	💔	$12.00$	$+1.29$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
ocPostprob	💔	$23.44$	$+7.22$	ocPostprob_gives_results_that_are_within_range_to_stats_pbinom
ocPostprob	💔	$13.31$	$+3.96$	the_PrEfficacy_increases_with_increase_Efficacy_looks
ocPostprob	💔	$15.41$	$+4.64$	the_PrFutility_increases_with_increase_futility_looks
ocPostprob	💔	$4.81$	$+1.54$	the_sum_of_Eff_Fut_Gray_zone_probabiliy_is_1
ocPostprobDist	👶		$+0.03$	h_get_decisionDist_gives_correct_result_relativeDelta_FALSE
ocPostprobDist	👶		$+0.02$	h_get_decisionDist_gives_correct_result_when_nnE_U_2260_nnF
ocPostprobDist	👶		$+0.06$	h_get_decisionDist_gives_correct_result_when_relativeDelta_TRUE

Results for commit 3183023

♻️ This comment has been updated with latest results.