Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean #44

Merged
merged 15 commits into from
Jan 5, 2024
Merged

clean #44

merged 15 commits into from
Jan 5, 2024

Conversation

audreyyeoCH
Copy link
Collaborator

closes #43

@audreyyeoCH audreyyeoCH marked this pull request as ready for review January 3, 2024 14:02
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Unit Tests Summary

    1 files      9 suites   2m 2s ⏱️
   88 tests    88 ✅ 0 💤 0 ❌
1 138 runs  1 138 ✅ 0 💤 0 ❌

Results for commit c88ba9f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ocPostprob 💔 $57.12$ $+31.54$ $+1007$ $0$ $0$ $0$
ocPostprobDist 💔 $0.09$ $+16.77$ $+8$ $0$ $0$ $0$
predprobDist 💔 $12.01$ $+2.83$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ocPostprob 👶 $+0.05$ h_dist0_works_as_expected
ocPostprob 👶 $+4.83$ h_get_looks_together_with_h_get_distance_always_gives_unique_looks
ocPostprob 💔 $23.37$ $+11.19$ ocPostprob_gives_results_that_are_within_range_to_stats_pbinom
ocPostprob 💔 $13.34$ $+6.17$ the_PrEfficacy_increases_with_increase_Efficacy_looks
ocPostprob 💔 $15.50$ $+6.98$ the_PrFutility_increases_with_increase_futility_looks
ocPostprob 💔 $4.81$ $+2.28$ the_sum_of_Eff_Fut_Gray_zone_probabiliy_is_1
ocPostprobDist 👶 $+1.79$ the_PrEfficacy_increases_with_increase_Efficacy_looks
ocPostprobDist 👶 $+3.10$ the_PrFutility_increases_with_increase_futility_looks
ocPostprobDist 👶 $+11.84$ the_sum_of_Eff_Fut_Gray_zone_probabiliy_is_1

Results for commit bdb85fb

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

🧪 Test coverage: 35.46%

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ------------
R/betadiff.R                59       0  100.00%
R/boundsPostprob.R          31      31  0.00%    35-74
R/boundsPredprob.R          28      28  0.00%    40-77
R/dbetabinom.R              60       3  95.00%   32, 62, 132
R/helpers.R                 17      15  11.76%   10-57
R/oc2.R                    162     162  0.00%    99-332
R/oc3.R                    146     146  0.00%    97-314
R/ocPostprob.R              95       4  95.79%   246-249
R/ocPostprobDist.R         108       0  100.00%
R/ocPredprob.R              53      53  0.00%    68-138
R/ocPredprobDist.R          63      63  0.00%    70-149
R/ocRctPostprobDist.R      107     107  0.00%    81-224
R/ocRctPredprobDist.R      104     104  0.00%    86-227
R/plotBeta.R               107     107  0.00%    16-174
R/plotBounds.R              52      52  0.00%    37-94
R/plotDecision.R            79      79  0.00%    19-139
R/plotOc.R                  15      15  0.00%    16-36
R/postprob.R                29       1  96.55%   102
R/postprobDist.R            78       1  98.72%   212
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       3  97.86%   271-272, 275
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumbetadiff.R             63      63  0.00%    27-104
R/sumTable.R                20      20  0.00%    25-48
TOTAL                     1644    1061  35.46%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/ocPostprobDist.R      -11     -69  +57.98%
TOTAL                   -11     -69  +3.74%

Results for commit: c88ba9f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Daniel Sabanes Bove and others added 3 commits January 4, 2024 13:16
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audreyyeoCH , looks nice, just some minor comments

R/ocPostprob.R Outdated Show resolved Hide resolved
R/ocPostprob.R Show resolved Hide resolved
R/ocPostprob.R Outdated Show resolved Hide resolved
R/ocPostprob.R Outdated Show resolved Hide resolved
@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive the git checks have passed, can you review please ?

@audreyyeoCH audreyyeoCH merged commit 91b5d6e into main Jan 5, 2024
22 checks passed
@audreyyeoCH audreyyeoCH deleted the 43_ocPostprobDist branch January 5, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

43_ocPostprobDist
2 participants