Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

res-> result, removed randomdist in vignette too, clean #46

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

audreyyeoCH
Copy link
Collaborator

closes #40

@audreyyeoCH audreyyeoCH marked this pull request as ready for review January 5, 2024 10:16
@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive, local checks passed, could you review please ?

Copy link
Contributor

github-actions bot commented Jan 5, 2024

🧪 Test coverage: 35.42%

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ------------
R/betadiff.R                59       0  100.00%
R/boundsPostprob.R          31      31  0.00%    35-74
R/boundsPredprob.R          28      28  0.00%    40-77
R/dbetabinom.R              60       3  95.00%   32, 62, 132
R/helpers.R                 17      15  11.76%   10-57
R/oc2.R                    162     162  0.00%    99-332
R/oc3.R                    146     146  0.00%    97-314
R/ocPostprob.R              94       4  95.74%   242-245
R/ocPostprobDist.R         108       0  100.00%
R/ocPredprob.R              53      53  0.00%    68-138
R/ocPredprobDist.R          63      63  0.00%    70-149
R/ocRctPostprobDist.R      107     107  0.00%    81-224
R/ocRctPredprobDist.R      104     104  0.00%    86-227
R/plotBeta.R               107     107  0.00%    16-174
R/plotBounds.R              52      52  0.00%    37-94
R/plotDecision.R            79      79  0.00%    19-139
R/plotOc.R                  15      15  0.00%    16-36
R/postprob.R                29       1  96.55%   102
R/postprobDist.R            78       1  98.72%   212
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       3  97.86%   271-272, 275
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumbetadiff.R             63      63  0.00%    27-104
R/sumTable.R                20      20  0.00%    25-48
TOTAL                     1643    1061  35.42%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/ocPostprob.R           -1       0  -0.04%
R/ocPostprobDist.R      -11     -69  +57.98%
TOTAL                   -12     -69  +3.70%

Results for commit: 31f939b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Unit Tests Summary

    1 files      9 suites   2m 37s ⏱️
   88 tests    88 ✅ 0 💤 0 ❌
1 138 runs  1 138 ✅ 0 💤 0 ❌

Results for commit 31f939b.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ocPostprob 💔 $57.12$ $+57.26$ $+1007$ $0$ $0$ $0$
ocPostprobDist 💔 $0.09$ $+21.27$ $+8$ $0$ $0$ $0$
predprobDist 💔 $12.01$ $+7.30$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ocPostprob 👶 $+0.05$ h_dist0_works_as_expected
ocPostprob 👶 $+5.10$ h_get_looks_together_with_h_get_distance_always_gives_unique_looks
ocPostprob 💔 $23.37$ $+20.99$ ocPostprob_gives_results_that_are_within_range_to_stats_pbinom
ocPostprob 💔 $13.34$ $+12.39$ the_PrEfficacy_increases_with_increase_Efficacy_looks
ocPostprob 💔 $15.50$ $+14.38$ the_PrFutility_increases_with_increase_futility_looks
ocPostprob 💔 $4.81$ $+4.29$ the_sum_of_Eff_Fut_Gray_zone_probabiliy_is_1
ocPostprobDist 👶 $+2.31$ the_PrEfficacy_increases_with_increase_Efficacy_looks
ocPostprobDist 👶 $+3.94$ the_PrFutility_increases_with_increase_futility_looks
ocPostprobDist 👶 $+14.95$ the_sum_of_Eff_Fut_Gray_zone_probabiliy_is_1
predprobDist 💔 $1.83$ $+1.18$ h_predprobdist_gives_correct_list
predprobDist 💔 $3.66$ $+2.28$ h_predprobdist_gives_higher_predictive_probability_when_thetaT_is_lower
predprobDist 💔 $3.62$ $+2.26$ predprobDist_gives_higher_predictive_probability_when_thetaT_is_lower_in_a_single_arm_trial
predprobDist 💔 $1.87$ $+1.01$ predprobDist_gives_the_correct_results_in_a_two_arm_study

Results for commit 851a32c

♻️ This comment has been updated with latest results.

@audreyyeoCH audreyyeoCH merged commit 2c2e25c into main Jan 5, 2024
40 checks passed
@audreyyeoCH audreyyeoCH deleted the 40_fix_randomdist_wiggle branch January 5, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix randomdist = wiggle
2 participants