-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZH-253 #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you did a great job transferring the text from the Google Doc to Markdown! I especially liked the figures—they really help to clarify the text. Well done!
I’ve made a few comments on areas that might need some adjustments. I noticed that not all parts of the SOP were completed in the Google Doc, and they’re still missing here. I’m not sure if we need to finalize sections like 7.3 and 7.4 before we release the SOP. Overall, though, you’ve done excellent work with lots of potential for further improvement! :-)
Co-authored-by: M-casado <[email protected]>
Co-authored-by: M-casado <[email protected]>
Co-authored-by: M-casado <[email protected]>
Co-authored-by: M-casado <[email protected]>
Co-authored-by: GabiRinck <[email protected]>
Co-authored-by: M-casado <[email protected]>
Deleting Document not in use
Deleting Document not in use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
Deleting unnecessary file
Deleting unnecessary file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new image a lot, well done. I haven't gone through all previous changes, but I assume they're resolved 👍
The only three things I noticed and would request changes:
- You added a new
.DS_Store
that shouldn't be in the PR - Before merging this PR, change the name of the main file as mentioned above
- Add your changes to the
CHANGELOG
file following its format (i.e. a line like ``information-service.... ... - Document detailing ...")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added some suggestions in the new section
Co-authored-by: M-casado <[email protected]>
Co-authored-by: M-casado <[email protected]>
Co-authored-by: M-casado <[email protected]>
Co-authored-by: M-casado <[email protected]>
Co-authored-by: M-casado <[email protected]>
Changes requested in the review
Correct File name
Adding the IMS to the Changelog
Summary
Adding the ISM documentation and schemas
Types of changes
Motivation and Context
Adding the ISM documentation and schemas
References
ZenHub #253
Changes Introduced
Review
Documentation that will be modified in the future as some aspects of the SOP life cycle are define.
Additional Notes
Checklist:
General Compliance:
Only applicable if the PR includes new, or changes to, GDI SOPs (i.e., documents at
sops/
):