Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check if MANE transcript exists in UTA, if not select longest compatible #378

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

fix: Check if MANE transcript exists in UTA, if not select longest compatible #378

wants to merge 7 commits into from

Conversation

jarbesfeld
Copy link
Contributor

@jarbesfeld jarbesfeld commented Nov 12, 2024 •
edited
Loading

Closes #377

@jarbesfeld jarbesfeld requested a review from korikuzma November 12, 2024 22:52
@jarbesfeld jarbesfeld self-assigned this Nov 12, 2024
korikuzma
korikuzma requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick initial review

src/cool_seq_tool/sources/uta_database.py Outdated Show resolved Hide resolved
src/cool_seq_tool/sources/uta_database.py Outdated Show resolved Hide resolved
src/cool_seq_tool/mappers/exon_genomic_coords.py Show resolved Hide resolved
src/cool_seq_tool/mappers/exon_genomic_coords.py Show resolved Hide resolved
@jarbesfeld jarbesfeld requested a review from korikuzma November 13, 2024 19:43
@jarbesfeld jarbesfeld requested a review from korikuzma November 14, 2024 14:52
@korikuzma korikuzma removed their request for review November 14, 2024 15:18
@korikuzma
Copy link
Member

@jarbesfeld said he is still looking into things. Please re-request my review when ready

@jarbesfeld jarbesfeld requested a review from korikuzma November 14, 2024 16:13
@korikuzma korikuzma removed their request for review November 15, 2024 18:24
@korikuzma
Copy link
Member

@jarbesfeld is waiting to hear if UTA will be updated (which may resolve this issue). Removing my review for now. @jarbesfeld Should we convert this to a draft PR?

@jarbesfeld
Copy link
Contributor Author

@korikuzma yes we should convert to a draft PR for now

@korikuzma korikuzma marked this pull request as draft November 15, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korikuzma korikuzma korikuzma requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@jarbesfeld jarbesfeld

Labels
priority:high High priority stale-exempt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

genomic_to_tx_segment should check if a MANE Select transcript is in UTA
2 participants
@jarbesfeld @korikuzma