Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Add support for residue coords + refactor offset calculation #384

Merged
merged 13 commits into from
Jan 7, 2025

Conversation

jarbesfeld
Copy link
Contributor

@jarbesfeld jarbesfeld commented Dec 4, 2024

closes #383 and #389

  • This PR includes a refactor of the exon offset calculation to make this step more efficient and understandable
  • This PR also includes support for residue coordinates. The fusion callers I've been working with output residue-coordinates, so when the offset is computed with respect to alt_start_i, the genomic position must be reduced by 1 as the exon boundaries provided by UTA are inter-residue coordinates. This adjustment is not needed however when the offset is computed using the genomic coordinate in alt_end_i

@jarbesfeld jarbesfeld added bug Something isn't working priority:high High priority labels Dec 4, 2024
@jarbesfeld jarbesfeld self-assigned this Dec 4, 2024
@jarbesfeld jarbesfeld requested a review from korikuzma December 9, 2024 14:10
korikuzma
korikuzma previously approved these changes Dec 9, 2024
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good to me. Relying on @ahwagner to confirm logic makes sense.

@jarbesfeld jarbesfeld removed the request for review from korikuzma January 2, 2025 18:59
@jarbesfeld jarbesfeld requested a review from korikuzma January 2, 2025 19:38
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick initial review. I'm going to have to take more time to review the changes.

@jarbesfeld jarbesfeld requested a review from korikuzma January 6, 2025 20:52
@jarbesfeld jarbesfeld requested a review from korikuzma January 7, 2025 17:08
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing

@jarbesfeld jarbesfeld requested a review from korikuzma January 7, 2025 17:44
@jarbesfeld jarbesfeld merged commit da888fe into main Jan 7, 2025
12 checks passed
@jarbesfeld jarbesfeld deleted the issue-383 branch January 7, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high High priority stale-exempt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for residue-coordinates and refactor exon offset
2 participants