skater spanning tree weights properties incorrect

[lanselin]

See also #1763 and #1764. The properties of the skater weights file are not correct in the weights manager. In part, this is because the lack of symmetric entries (#1764), and the lack of an id variable (#1763), but also the type is given as "custom" and the symmetry is given as "unknown".

To keep consistency with the other weights files, the type should be given as "skater" and the symmetry should be given as symmetric (and the id variable listed). This then would allow the information to be saved in a project file for future use.

[Ashitacarl]

GeoDa 1.12.1.181 (macOS Mojave, 10.14.1). Dec. 10 build.

In the weights manager, the saved skater gwt weight now is identified as "symmetric".
But the type is "custom" which should be changed into "skater".

[lixun910]

@Ashitacarl This is correct: when you create the skater.gwt, GeoDa knows it is symmetric -- just like when you create any distance based weights. However, when you load skater.gwt from an external file, GeoDa doesn't detect if it's symmetric or not, so it will be marked as "custom".

[Ashitacarl]

@lixun910 But this one is saved from "Saving Spinning Tree" rather than "Loaded" from an external file. So, the type should be "skater" rather than "custom". The "symmetric" label is correct!

[lixun910]

@Ashitacarl oh, sorry. I see now. We don't have a type "skater", which is basically a name of a spatially constrained clustering method.

[lanselin]

I suggest we add a type skater for the weights manager properties, at least when the file is stored in a project file. when loaded from gwt, it will say custom, since there is no metadata, but when loaded from a project file, there is no reason (as far as I know) to not have it stored as “skater”.

…

On Dec 17, 2018, at 6:06 PM, Xun Li ***@***.***> wrote: @Ashitacarl oh, sorry. I see now. We don't have a type "skater", which is basically a name of a spatially constrained clustering method. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[lixun910]

Got it. What about the "save spanning tree" function in "Redcap"? Do you want to name it as "redcap" or "skater"? since they are actually the same -- a spanning tree saved in the format of GWT.

[lanselin]

Good point. Let’s call it “tree” as the type.

…

On Dec 18, 2018, at 9:51 PM, Xun Li ***@***.***> wrote: Got it. What about the "save spanning tree" function in "Redcap"? Do you want to name it as "redcap" or "skater"? since they are actually the same -- a spanning tree saved in the format of GWT. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Ashitacarl]

GeoDa 1.12.1.183 (macOS Mojave, 10.14.1). Dec. 19 build.
Dataset: Guerry sample data.

Fix verified. "Tree" now included as the type for both skater and redcap.