Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category Editor interface #256

Closed
jkoschinsky opened this issue Nov 23, 2015 · 6 comments
Closed

Category Editor interface #256

jkoschinsky opened this issue Nov 23, 2015 · 6 comments

Comments

@jkoschinsky
Copy link
Collaborator

Let’s go back to listing the minimum on top of the slider and the max at the bottom like we used to have since it’s otherwise hard to tell what these two numbers mean.

  • take out:
    • line above “define custom breaks” and “define custom breaks header” so there’s just two categories:
      “create custom breaks” and edit custom breaks
    • preview var option below histogram preview and keep “same as assoc var as default”
  • move “assoc. var” and the variable selection to its right above “Breaks”
  • change default setting to user-defined, quantile, 4 categories
  • sometimes when you first open the Category Editor with the default of user defined categories, the slider is gone
  • right-click/options for maps, cartograms and bubble charts, PCP, Conditional Map:
    • Create New Custom and list names of the new categories you created but remove other custom breaks from list
  • The cartogram contains a “Save Categories” option. Let’s add this as a button at the bottom of the category editor. This option is disabled for user defined categories.
@jkoschinsky
Copy link
Collaborator Author

These two changes aren't implemented yet:

  • change default setting to user-defined, quantile, 4 categories (current default is quantile)
  • The cartogram contains a “Save Categories” option. Let’s add this as a button at the bottom of the category editor. This option is disabled for user defined categories.

Let's discuss tomorrow if we want these for 1.8 or later.

@lixun910
Copy link
Member

lixun910 commented Mar 3, 2016

crash: when create a new "custom category" in histogram, close it. Then, open "Category Editor" again, select just created "custom category". It will crash.

@jkoschinsky
Copy link
Collaborator Author

default settings fine with quantile

The cartogram contains a “Save Categories” option. Let’s add this as a button at the bottom of the category editor. This option is disabled for user defined categories.

lixun910 added a commit that referenced this issue Mar 4, 2016
The crash of Category Editor in Histogram is caused by a uncleaned
linking code that tries to find already closed histogram.

This fix also update the plist to support crisp font in Retina display.
The icon/drawing code still needs a solution.
@lixun910
Copy link
Member

lixun910 commented Mar 4, 2016

The crash has been fixed. You can verify it using 1.7.89

lixun910 added a commit that referenced this issue Mar 5, 2016
lixun910 added a commit that referenced this issue Mar 5, 2016
The cartogram contains a “Save Categories” option. Let’s add this as a
button at the bottom of the category editor.
@lixun910
Copy link
Member

lixun910 commented Mar 6, 2016

please verify in 1.7.91

@jkoschinsky
Copy link
Collaborator Author

Verified fix in GeoDa 1.7.91 (OSX Yosemite, 10.10.5 and Win 7 Professional (64-bit)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants