Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOWESS regression crashed on 64-bit windows #292

Closed
lixun910 opened this issue Jan 15, 2016 · 2 comments
Closed

LOWESS regression crashed on 64-bit windows #292

lixun910 opened this issue Jan 15, 2016 · 2 comments
Assignees
@lixun910
Labels
bug
Milestone
1.8

Comments

@lixun910
Copy link
Member

The algorithm of LOWESS regression has a bug when use std::partial_sort() function. It's definition is:

template< class RandomIt >
void partial_sort( RandomIt first, RandomIt middle, RandomIt last );

The usage in ShapeOperations\Lowess.cpp gives wrong parameters, and cause "invalid iteration" error and a crash.

This error has been ignored on Mac OSX as well as 32-bit windows (no crash on these platforms).
@lixun910 lixun910 added the bug label Jan 15, 2016
@lixun910 lixun910 self-assigned this Jan 15, 2016
@lixun910 lixun910 added this to the 1.8 milestone Jan 15, 2016
lixun910 added a commit that referenced this issue Jan 15, 2016
@lixun910
fix issue #292 #288
e2d0784 
#288 causes crash due to large number of observations (>70000) generates
too many pairs (which is set as default) and cause memory issue and
crash in non-parametric correlogram. So, a detection is added to set
"Random Sample" as default when observation number is larger than 10000.

Note: this crash only appears on Windows platform.
@jkoschinsky
Copy link
Collaborator

Verified fix in GeoDa 1.7.87 ( Win 7 Professional (64-bit): No more crash.

Could you confirm that the iterations are active: Nothing changes for different iterations, even in small datasets. If it's active, you can close the ticket.

@lixun910
Copy link
Member Author

lixun910 commented Mar 5, 2016

Verified via debug, the iterations are active.

@lixun910 lixun910 closed this as completed Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lixun910 lixun910

Labels
bug
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
2 participants
@lixun910 @jkoschinsky