Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save automatically creates project file #386

Closed
lanselin opened this issue Apr 1, 2016 · 8 comments
Closed

save automatically creates project file #386

lanselin opened this issue Apr 1, 2016 · 8 comments

Comments

@lanselin
Copy link
Collaborator

lanselin commented Apr 1, 2016

after making some changes to a table (e.g., editing a variable name) and using Save (either the toolbar button or the File > Save command), a project file is automatically created, even when none exists. is that the desired behavior? I would suggest not creating a project file when none currently exists, and only creating it when there already is one. This is "save" of a "current" state, so why create new files.

@lanselin
Copy link
Collaborator Author

lanselin commented Apr 1, 2016

forgot to specify using 1.7.101

@jkoschinsky
Copy link
Collaborator

did you have weights specified?

On 1 April 2016 at 07:45, Luc Anselin [email protected] wrote:

forgot to specify using 1.7.101


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
lixun910#386 (comment)


Julia Koschinsky, Ph.D.
Research Director
Associate Research Professor
Arizona State University
School of Geographical Sciences and Urban Planning
GeoDa Center for Geospatial Analysis and Computation
[email protected]

http://geodacenter.asu.edu
http://www.facebook.com/geodacenter
http://twitter.com/GeoDaCenter

@lanselin
Copy link
Collaborator Author

lanselin commented Apr 1, 2016

no weights, only operation was to convert a csv file (non-spatial) to a dbf file and edit
the variable names that were too long for dbf.

On Apr 1, 2016, at 9:49 AM, jkoschinsky [email protected] wrote:

did you have weights specified?

On 1 April 2016 at 07:45, Luc Anselin [email protected] wrote:

forgot to specify using 1.7.101


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
lixun910#386 (comment)


Julia Koschinsky, Ph.D.
Research Director
Associate Research Professor
Arizona State University
School of Geographical Sciences and Urban Planning
GeoDa Center for Geospatial Analysis and Computation
[email protected]

http://geodacenter.asu.edu
http://www.facebook.com/geodacenter
http://twitter.com/GeoDaCenter

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub lixun910#386 (comment)

@jkoschinsky
Copy link
Collaborator

I agree, I think it makes sense to automatically save the project file when
time groups are specified (and possibly weights) so those specifications
aren't inadvertently lost but not otherwise.

On 1 April 2016 at 07:50, Luc Anselin [email protected] wrote:

no weights, only operation was to convert a csv file (non-spatial) to a
dbf file and edit
the variable names that were too long for dbf.

On Apr 1, 2016, at 9:49 AM, jkoschinsky [email protected]
wrote:

did you have weights specified?

On 1 April 2016 at 07:45, Luc Anselin [email protected] wrote:

forgot to specify using 1.7.101


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
lixun910#386 (comment)


Julia Koschinsky, Ph.D.
Research Director
Associate Research Professor
Arizona State University
School of Geographical Sciences and Urban Planning
GeoDa Center for Geospatial Analysis and Computation
[email protected]

http://geodacenter.asu.edu
http://www.facebook.com/geodacenter
http://twitter.com/GeoDaCenter

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub <
https://github.com/lixun910/geoda/issues/386#issuecomment-204424892>


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
lixun910#386 (comment)


Julia Koschinsky, Ph.D.
Research Director
Associate Research Professor
Arizona State University
School of Geographical Sciences and Urban Planning
GeoDa Center for Geospatial Analysis and Computation
[email protected]

http://geodacenter.asu.edu
http://www.facebook.com/geodacenter
http://twitter.com/GeoDaCenter

lixun910 added a commit that referenced this issue Apr 1, 2016
Add restriction to automatically save the project file when
time groups are specified
@lixun910 lixun910 added the bug label Apr 4, 2016
@lixun910 lixun910 added this to the 1.8 milestone Apr 4, 2016
@lixun910
Copy link
Member

lixun910 commented Apr 6, 2016

Please verify in 1.7.103

@jkoschinsky
Copy link
Collaborator

1.7.103

Right now when you specify time or weights and save/close, the project file isn't added, so you would lose the time groupings and loaded weights. For those two cases (having time groupings or weights), can we automatically add a project file so these specs aren't lost?

@lanselin
Copy link
Collaborator Author

lanselin commented Apr 6, 2016

i have also had some instances where the weights information was not saved into the project
file when closing the project, but i cannot replicate right now.

On Apr 6, 2016, at 4:13 PM, jkoschinsky [email protected] wrote:

1.7.103

Right now when you specify time or weights and save/close, the project file isn't added, so you would lose the time groupings and loaded weights. For those two cases (having time groupings or weights), can we automatically add a project file so these specs aren't lost?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub lixun910#386 (comment)

lixun910 added a commit that referenced this issue Apr 7, 2016
make sure weights definition or changes are saved to project file.
@jkoschinsky
Copy link
Collaborator

Verified in GeoDa 1.7.103 (OSX Yosemite, 10.10.5

Confirmed that .gda file is now saved with either weights or time grouped variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants