Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes ISSUE 259] Loading of dataset fails if domain contains geoserver #301

Merged
merged 7 commits into from
Nov 28, 2024
Merged

[Fixes ISSUE 259] Loading of dataset fails if domain contains geoserver #301

merged 7 commits into from
Nov 28, 2024

Conversation

Gpetrak
Copy link
Contributor

@Gpetrak Gpetrak commented Nov 28, 2024

This PR fixes the issue #259 . It includes a function which re-formats the URLs from GeoServer including services (gs/ows) and SLD.

@Gpetrak Gpetrak marked this pull request as ready for review November 28, 2024 08:26
@Gpetrak Gpetrak requested a review from giohappy November 28, 2024 08:26
giohappy
giohappy requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@giohappy giohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gpetrak please add unit tests for url_from_geoserver where a few different cases are tested, including the example reported in the issue.

@giohappy giohappy linked an issue Nov 28, 2024 that may be closed by this pull request
Loading of dataset fails if domain contains geoserver #259
Closed
@giohappy giohappy self-requested a review November 28, 2024 10:47
giohappy
giohappy requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@giohappy giohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gpetrak tests are failing

@Gpetrak
Copy link
Contributor Author

Gpetrak commented Nov 28, 2024

@giohappy done !

@giohappy giohappy merged commit 678eac2 into main Nov 28, 2024
3 checks passed
@giohappy giohappy deleted the ISSUE_259 branch November 28, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giohappy giohappy giohappy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading of dataset fails if domain contains geoserver
2 participants
@Gpetrak @giohappy