GeoNode CSW catalog requires the dc:type=dataset filtert

[giohappy]

Services and maps are going to be exposed by the CSW catalogue.
To avoid listing these resources inside the MapStore client catalog a filter must be always included:

<csw:Constraint version="1.1.0">
  <Filter xmlns="http://www.opengis.net/ogc">
	<PropertyIsEqualTo>
	  <PropertyName>dc:type</PropertyName>
	  <Literal>dataset</Literal>
	</PropertyIsEqualTo>
  </Filter>
</csw:Constraint>

This must be positioned after csw:ElementSetName element

The expected results in catalog should be only layers (dc:type equal to dataset) but currently other resources are visible.
Below screenshot of the current Catalog showing resources different from layers.

Note: This issue needs to be fixed on MapStore first probably so we should do a quick investigation to understand which part of the code need to be fixed.

[giohappy]

@allyoucanmap as confirmed by @etj we can safely adopt this filter upstream in MapStore.

[allyoucanmap]

connected to geosolutions-it/MapStore2#6813

[MuhweziDeo]

@giohappy @etj testing this filter in Mapstore

<csw:Constraint version="1.1.0">
 <Filter xmlns="http://www.opengis.net/ogc">
   <PropertyIsEqualTo>
     <PropertyName>dc:type</PropertyName>
     <Literal>dataset</Literal>
   </PropertyIsEqualTo>
 </Filter>
</csw:Constraint>.

It seems not to be working because responses received do not change I also noticed that the records returned even non-layers have dc:type === dataset. I do not know maybe there something I am missing but the final XML body constructed looks like this when there is no search text

<csw:GetRecords xmlns:csw="http://www.opengis.net/cat/csw/2.0.2"
     xmlns:ogc="http://www.opengis.net/ogc"
     xmlns:gml="http://www.opengis.net/gml"
     xmlns:dc="http://purl.org/dc/elements/1.1/"
     xmlns:dct="http://purl.org/dc/terms/"
     xmlns:gmd="http://www.isotc211.org/2005/gmd"
     xmlns:gco="http://www.isotc211.org/2005/gco"
     xmlns:gmi="http://www.isotc211.org/2005/gmi"
     xmlns:ows="http://www.opengis.net/ows" service="CSW" version="2.0.2" resultType="results" startPosition="${startPosition}" maxRecords="${maxRecords}">
     <csw:Query typeNames="csw:Record">
         <csw:ElementSetName>full</csw:ElementSetName>
         <csw:Constraint version="1.1.0">
             <ogc:Filter>
                 <ogc:PropertyIsEqualTo>
                     <ogc:PropertyName>dc:type</ogc:PropertyName>
                     <ogc:Literal>dataset</ogc:Literal>
                 </ogc:PropertyIsEqualTo>
             </ogc:Filter>
         </csw:Constraint>
     </csw:Query>
 </csw:GetRecords>

one of the records which are not layer includes the one below and you can see dc:type is dataset

[giohappy]

@MuhweziDeo can you please report the CSW service URL that you used in your example?

[MuhweziDeo]

@MuhweziDeo can you please report the CSW service URL that you used in your example?

@giohappy this is the URL hit on GeoServer http://localhost:8000/catalogue/csw?service=CSW&version=2.0.2&request=

[giohappy]

@MuhweziDeo so the record you are reporting is something in your local GeoNode. You say it's not a layer, what is it then?

[MuhweziDeo]

@MuhweziDeo so the record you are reporting is something in your local Geoserver. You say it's not a layer, what is it then?

it's a Map @giohappy

[giohappy]

checking with @etj

[giohappy]

The fact that resources different from layers are returned by the CSW Catalogue is a regression / side effect of a recent change to GeoNode.
https://github.com/geosolutions-it/C183-ALMAVIVA-2020-GeoNode-DEV/issues/210

When this will be fixed you should only get layers.

[MuhweziDeo]

@giohappy just to point this out. Within Mapstore2 the CSW catalog using this URL https://gs-stable.geo-solutions.it/geoserver/csw?service=CSW&version=2.0.2&request= returns empty response on applying the filter
<csw:Constraint version="1.1.0"> <Filter xmlns="http://www.opengis.net/ogc"> <PropertyIsEqualTo> <PropertyName>dc:type</PropertyName> <Literal>dataset</Literal> </PropertyIsEqualTo> </Filter> </csw:Constraint>
This because the dc:type being returned from current CSW Catalog response for mapstore2 is different. This is what it looks <dc:type>http://purl.org/dc/dcmitype/Dataset</dc:type>

ScreenShot

So in conclusion for Mapstore2 this filter works okay <dc:type>http://purl.org/dc/dcmitype/Dataset</dc:type> while for geonode-mapstore-client the filter <dc:type>dataset</dc:type> doesnot not introduce any changes maybe pending the fix https://github.com/geosolutions-it/C183-ALMAVIVA-2020-GeoNode-DEV/issues/210.

[giohappy]

I see @MuhweziDeo.
Thanks for the report. Let's wait @etj for inputs from him. I don't know if both the types of responses are correct and both should be expected....

[MuhweziDeo]

@giohappy With the latest fixes in the stable branch. Currently, all the responses are being returned without the non-layers. I applied the new filter but with or without the responses returned only have layer data. I believe no further is required even on https://master.demo.geonode.org/maps/1855/view#/ the responses only have layers from the catalog.

[giohappy]

Yes @MuhweziDeo that's expected, since with a normal configuration GeoNode's CSW only returns layers. BTW there are contexts where services are also returned.

[MuhweziDeo]

Okay @giohappy Should we proceed to close this issue without any further action

[giohappy]

Probably I didn't explain myself clearly @MuhweziDeo.
The filter MUST be set as said above. You won't see any difference when used with a normal GeoNode, but ti deosn't mean we don't need that filter.

[MuhweziDeo]

Probably I didn't explain myself clearly @MuhweziDeo.
The filter MUST be set as said above. You won't see any difference when used with a normal GeoNode, but ti deosn't mean we don't need that filter.

okay

[allyoucanmap]

@MuhweziDeo We should make a PR to geonode-mapstore-client branch 2.1.x with the MapStore2 submodule updated pointing to branch geonode-mapstore-client-2.1.x as soon as this fix has been backported and merged on the branch geonode-mapstore-client-2.1.x of MapStore2