Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1937: Fix layers settings for internal layers #1943

Merged
merged 1 commit into from
Feb 5, 2025
Merged

#1937: Fix layers settings for internal layers #1943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions geonode_mapstore_client/static/mapstore/configs/localConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@
{
"name": "gnResourceSelectedLayerDataset",
"path": "gnresource.selectedLayerDataset"
},
{
"name": "selectedLayer",
"path": "gnresource.selectedLayer"
Comment on lines +90 to +93
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsuren1 is it possible to use just one of gnResourceSelectedLayerDataset or selectedLayer or do they are different?
Could you investigate on where the gnResourceSelectedLayerDataset is used and if it can be replaced by selectedLayer, thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allyoucanmap It seems each holds a different data. selectedLayer holds selected node (layer) and selectedLayerDataset holds dataset info available in mapLayers by selected node

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the dataset fetch is asynchronous, there is a visual transition between TOCItemSetting and the LayerSetting plugin as the dataset is being retrieved. Therefore, I believe we should proceed with the current implementation as agreed

}
],
"projectionDefs": [],
Expand Down
Loading