Skip to content

Commit

Permalink
Remove get_default_access_permissions from harvester
Browse files Browse the repository at this point in the history
  • Loading branch information
meomancer committed Jul 9, 2021
1 parent 8e97218 commit 2577662
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 16 deletions.
1 change: 0 additions & 1 deletion geonode/harvesting/api/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ class Meta:
"scheduling_enabled",
"update_frequency",
"default_owner",
"default_access_permissions",
"harvester_type",
"harvester_type_specific_configuration",
"update_frequency",
Expand Down
4 changes: 0 additions & 4 deletions geonode/harvesting/harvesters/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,6 @@ def update_geonode_resource(
f"the remote resource {harvested_info.resource_descriptor.uuid!r}")
geonode_resource = resource_manager.update(
str(harvested_info.resource_descriptor.uuid), vals=defaults)
resource_manager.set_permissions(
str(harvested_info.resource_descriptor.uuid),
instance=geonode_resource,
permissions=harvester.default_access_permissions)
harvestable_resource.geonode_resource = geonode_resource
harvestable_resource.save()
self.finalize_resource_update(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ class Migration(migrations.Migration):
migrations.AlterField(
model_name='harvester',
name='default_access_permissions',
field=models.JSONField(default=geonode.harvesting.models.get_default_access_permissions, help_text='Default access permissions of harvested resources'),
field=models.JSONField(help_text='Default access permissions of harvested resources'),
),
]
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Generated by Django 3.2.4 on 2021-07-08 13:14

from django.db import migrations


class Migration(migrations.Migration):
dependencies = [
('harvesting', '0026_harvestableresource_last_harvesting_succeeded'),
]

operations = [
migrations.RemoveField(
model_name='harvester',
name='default_access_permissions',
),
]
10 changes: 0 additions & 10 deletions geonode/harvesting/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,6 @@
logger = logging.getLogger(__name__)


def get_default_access_permissions():
return {
"AnonymousUser": ["view"]
}


class Harvester(models.Model):
STATUS_READY = "ready"
STATUS_UPDATING_HARVESTABLE_RESOURCES = "updating-harvestable-resources"
Expand Down Expand Up @@ -105,10 +99,6 @@ class Harvester(models.Model):
on_delete=models.CASCADE,
help_text=_("Default owner of harvested resources")
)
default_access_permissions = models.JSONField(
default=get_default_access_permissions,
help_text=_("Default access permissions of harvested resources")
)
harvest_new_resources_by_default = models.BooleanField(
help_text=_(
"Should new resources be harvested automatically without "
Expand Down

0 comments on commit 2577662

Please sign in to comment.