-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code formatting with Black #10574
Comments
12 tasks
afabiani
pushed a commit
that referenced
this issue
Jan 24, 2023
* auto reformatting by black * relax flake8 * Add black to requirements * Add black to CircleCI (cherry picked from commit e0b7ec9) # Conflicts: # geonode/base/api/serializers.py # geonode/catalogue/tests.py # geonode/catalogue/urls.py # geonode/catalogue/views.py # geonode/geoserver/manager.py # geonode/geoserver/signals.py
etj
added a commit
that referenced
this issue
Jan 26, 2023
afabiani
added a commit
that referenced
this issue
Jan 26, 2023
#10585) * [Code Formatting] Revert formatting on conflicting files * [Fixes #10537] Improve rules creation using GeoFence batch - more improvements * [#10574] Align code formatting with black Co-authored-by: afabiani <[email protected]>
github-actions bot
pushed a commit
that referenced
this issue
Jan 26, 2023
#10585) * [Code Formatting] Revert formatting on conflicting files * [Fixes #10537] Improve rules creation using GeoFence batch - more improvements * [#10574] Align code formatting with black Co-authored-by: afabiani <[email protected]> (cherry picked from commit 36f414d)
afabiani
pushed a commit
that referenced
this issue
Jan 26, 2023
#10585) (#10588) * [Code Formatting] Revert formatting on conflicting files * [Fixes #10537] Improve rules creation using GeoFence batch - more improvements * [#10574] Align code formatting with black Co-authored-by: afabiani <[email protected]> (cherry picked from commit 36f414d) Co-authored-by: Emanuele Tajariol <[email protected]>
ridoo
pushed a commit
to Thuenen-GeoNode-Development/geonode
that referenced
this issue
Sep 18, 2023
…ore imp… (GeoNode#10585) (GeoNode#10588) * [Code Formatting] Revert formatting on conflicting files * [Fixes GeoNode#10537] Improve rules creation using GeoFence batch - more improvements * [GeoNode#10574] Align code formatting with black Co-authored-by: afabiani <[email protected]> (cherry picked from commit 36f414d) Co-authored-by: Emanuele Tajariol <[email protected]>
ridoo
pushed a commit
to Thuenen-GeoNode-Development/geonode
that referenced
this issue
Feb 22, 2024
…ore imp… (GeoNode#10585) (GeoNode#10588) * [Code Formatting] Revert formatting on conflicting files * [Fixes GeoNode#10537] Improve rules creation using GeoFence batch - more improvements * [GeoNode#10574] Align code formatting with black Co-authored-by: afabiani <[email protected]> (cherry picked from commit 36f414d) Co-authored-by: Emanuele Tajariol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As an effort to harmonize the coding style in GeoNode, the adoption of Black is being tested.
This is the current style adopted by Black
A branch where Black was run over all GeoNode code was created. It did a good job, and it worked well with
flake8
except for a few cases that are going to be excluded from flake8's config (E203, E731). E203, in particular, will be excluded since it's not a PEP8 requirement.Black will be included in the CI actions to enforce style conformance.
Developers are invited to run black, along with
flake8
, before opening PRs.The text was updated successfully, but these errors were encountered: