Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible typo in SPCGeonode docker-compose.yml file #5476

Closed
lucernae opened this issue Jan 8, 2020 · 1 comment · Fixed by #5475
Closed

Possible typo in SPCGeonode docker-compose.yml file #5476

lucernae opened this issue Jan 8, 2020 · 1 comment · Fixed by #5475
Assignees
@lucernae
Labels
docker Issues specific to GeoNode docker or GeoNode SPC major A high priority issue which might affect a lot of people or large parts of the codebase
Milestone
2.10.2

Comments

@lucernae
Copy link
Contributor

lucernae commented Jan 8, 2020

I have spotted a possible typo in docker-compose.yml recipe of SPCGeonode installation.
I refer to the installation guide here: http://docs.geonode.org/en/master/install/spc/index.html
The mentioned docker-compose.yml file is here:
https://github.com/GeoNode/geonode/blob/master/scripts/spcgeonode/docker-compose.yml
Corresponding environment file is here:
https://github.com/GeoNode/geonode/blob/master/scripts/spcgeonode/.env

According to the guide, the environment variables can be modified in the default .env file.
For specific database connection URL for Django and Geodatabase databases, devops can change corresponding credentials via GEONODE_DATABASE_USER and GEONODE_GEODATABASE_USER value in .env files.
However, by scanning docker-compose.yml, these value is not used anywhere and I suspect this is just a typo.
Currently the value of GEONODE_DATABASE and GEONODE_DATABASE_USER are the same default value. Then GEONODE_DATABASE environment variable is used in the place of user credentials field in database connection URL.

I propose that we change this to use the intended environment variable, which is GEONODE_DATABASE_USER

Expected Behavior

Different value of GEONODE_DATABASE and GEONODE_DATABASE_USER should work given the user and database access exists.

Actual Behavior

GEONODE_DATABASE_USER value is ignored.

Steps to Reproduce the Problem

  1. Modify .env file to use different value of existing user but with different name than the database name. There should be no user with the same name with the database to reproduce this problem.
  2. Spin up containers using docker-compose
  3. Django and Geoserver will fail to start/hang because the database connection URL is wrong.

Specifications

  • GeoNode version: master branch
  • Installation method (manual, GeoNode Docker, SPCGeoNode Docker): SPCGeoNode Docer
  • Platform: Any docker engine installed OS. Currently tested on Mac.
  • Additional details:
@lucernae
Copy link
Contributor Author

lucernae commented Jan 8, 2020

PR to as proposed has been submitted here: #5475

@lucernae lucernae mentioned this issue Jan 8, 2020
Merged
11 tasks
@gannebamm gannebamm added backport 2.10.x docker Issues specific to GeoNode docker or GeoNode SPC minor A low priority issue which might affect only some users and /or not the main functionality labels Jan 8, 2020
@afabiani afabiani added major A high priority issue which might affect a lot of people or large parts of the codebase and removed minor A low priority issue which might affect only some users and /or not the main functionality labels Jan 8, 2020
@afabiani afabiani added this to the 2.10.2 milestone Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucernae lucernae

Labels
docker Issues specific to GeoNode docker or GeoNode SPC major A high priority issue which might affect a lot of people or large parts of the codebase
Projects
None yet
Milestone
2.10.2
Development

Successfully merging a pull request may close this issue.

[Fixes #5476] Possible typo in SPCGeonode docker-compose.yml file lucernae/geonode
3 participants
@lucernae @afabiani @gannebamm