[Fixes #5476] Possible typo in SPCGeonode docker-compose.yml file

[lucernae]

• [Fixes Possible typo in SPCGeonode docker-compose.yml file #5476] Possible typo in SPCGeonode docker-compose.yml file

Change environment variable to refer GEONODE_DATABASE_USER
and GEONODE_GEODATABASE_USER respectively for user
field in database connections.

When testing GeoNode installation as described here in this document:
http://docs.geonode.org/en/master/install/spc/index.html
I did noticed that the environment variables has some typo.
The variables were defined in .env file but not used in docker-compose.yml in the appropriate location in database connection URL. Thus, I suspect this is a typo.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
• New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• This PR passes the QA checks: flake8 geonode
• Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @lucernae on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

[t-book]

Hi @lucernae
thanks for your contribution. Would you kindly sign the CLA as explained here: https://github.com/GeoNode/geonode/blob/master/CONTRIBUTING.md

Further, open an issue for your PR

There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end users)

The issue connected to the PR must have Labels and Milestone assigned

Thanks!

[lucernae]

Thank you @t-book . Previously I thought it was not required for one file small bug fix. Will do it as requested.

[t-book]

thanks @lucernae

[gannebamm]

strange, I use them and had not spotted any issues with the current env - even though I must admit they look wrong. Let´s see what the tests say.

[lucernae]

The default settings in .env have GEONODE_DATABASE and GEONODE_DATABASE_USER with the same value. So default settings works.

[gannebamm]

@lucernae Of course, my fault.
I see only selenium SPC failing on travis, which has nothing to do with these changes. I would approve them.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @lucernae on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

[codecov]

Codecov Report

Merging #5475 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5475   +/-   ##
=======================================
  Coverage   57.57%   57.57%           
=======================================
  Files         172      172           
  Lines       19299    19299           
  Branches     3006     3006           
=======================================
  Hits        11112    11112           
  Misses       7167     7167           
  Partials     1020     1020

[lucernae]

Hi @t-book @gannebamm , I've submitted the CLA as requested to [email protected] and [email protected]
I've also updated PR title according to the issue.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @lucernae on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @lucernae on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.