Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Layers in Map Info page should show title and not typename (also for remote layers) #678

Closed
jj0hns0n opened this issue Jan 15, 2013 · 4 comments
Assignees
Milestone

Comments

@jj0hns0n
Copy link
Contributor

No description provided.

@capooti
Copy link
Member

capooti commented Jan 23, 2013

The problem here is that in the map info pages we have access to the Map MapLayer set, so best option is to use the MapLayer title attribute.
If we want to use the Layer title attribute, we should consider to create a relation beween maps_maplayer and layers_layer. This would be useful also for maintaining referential integrity between the maps_maplayer/layers_layer combinations (now delegated to the layer post_delete_layer signal) and for many other db design reasons.
Such a decision would involve to store in layers_layer also remote layers, or have such a layer relation in maps_maplayer not mandatory (not null = true) for remote layers.

@simod
Copy link
Member

simod commented Jan 23, 2013

I can't see all the implication of doing that, but putting a foreign key in the MapLayer class means that Maps and Layers will be m2m related having MapLayer as an intermediate (through) class. Which makes sense to me.

@ghost ghost assigned simod Jun 22, 2013
@jj0hns0n
Copy link
Contributor Author

@simod this should not be hard now right?

@simod
Copy link
Member

simod commented Jun 24, 2013

fixed 2a19acf

@simod simod closed this as completed Jun 24, 2013
giohappy pushed a commit that referenced this issue Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants