Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thesauri in metadata details #7377

Closed
etj opened this issue Apr 23, 2021 · 2 comments
Closed

Thesauri in metadata details #7377

etj opened this issue Apr 23, 2021 · 2 comments
Assignees
Labels
feature A new feature to be added to the codebase frontend Issues regarding Frontend and styling
Milestone

Comments

@etj
Copy link
Contributor

etj commented Apr 23, 2021

Is your feature request related to a problem? Please describe.

Thesauri keywords are displayed along with free keyword, without any categorization.

Describe the solution you'd like

Thesauri keywords should be grouped, showing the thesaurus they belong to.
This change should be implemented in both:

  • layer info
  • metadata detail page.

Note that thesauri titles and keywords should be localized:

  • use ThesaurusLabel for localization and fallback to Thesaurus.title;
  • use use ThesaurusKeywordLabel for localization and fallback to ThesaurusKeyword.alt_title

e.g.:

image

This could be implemented by placing entries in a <ul> :

<dd>
   <ul>
      <li>free kw 1</li>
      <li>free kw 2</li>
      <li>free kw 3</li>
      <li>Thesaurus title 1
         <ul>
            <li>item1</li>
            <li>item2</li>
         </ul>
      </li>
      <li>Thesaurus title 2
         <ul>
            <li>item3</li>
            <li>item4</li>
         </ul>
      </li>
   </ul>   
</dd>

Describe alternatives you've considered
N/A

Additional context
N/A

@t-book t-book added the feature A new feature to be added to the codebase label Apr 23, 2021
@mattiagiupponi
Copy link
Contributor

Here is an example of how the keywords will be displayed:
Layer info:
image

Medatata details:
image

Is this fine @etj ?

mattiagiupponi added a commit to mattiagiupponi/geonode that referenced this issue Apr 27, 2021
@etj
Copy link
Contributor Author

etj commented Apr 27, 2021

It looks really good to me.
I would like to hear from @giohappy and @afabiani about the layer info page, where keywords may take a very large portion of the page.

@afabiani afabiani added this to the 3.2 milestone Apr 29, 2021
@afabiani afabiani added the frontend Issues regarding Frontend and styling label Apr 29, 2021
mattiagiupponi added a commit to mattiagiupponi/geonode that referenced this issue Apr 29, 2021
mattiagiupponi added a commit to mattiagiupponi/geonode that referenced this issue Apr 29, 2021
afabiani pushed a commit that referenced this issue Apr 29, 2021
* [Backport Resolves #7392] Fix upload/replace/append layer

* [Backport #7377] Thesauri in metadata details

* [Backport #7377] Fix flake8 formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature to be added to the codebase frontend Issues regarding Frontend and styling
Projects
None yet
Development

No branches or pull requests

5 participants