Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #10615] Implement fallback language for PyCSW to avoid warnings #10692

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

marthamareal
Copy link
Contributor

References #10615

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@marthamareal marthamareal self-assigned this Feb 24, 2023
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Feb 24, 2023
@marthamareal marthamareal changed the title - [Fixes #10615] Implement fallback language for PyCSW to avoid warnings [Fixes #10615] Implement fallback language for PyCSW to avoid warnings Feb 24, 2023
@giohappy giohappy requested a review from etj February 24, 2023 16:12
etj
etj previously approved these changes Feb 24, 2023
@giohappy
Copy link
Contributor

@marthamareal I think you have to use black to fix some formatting. Look at the failing tests.

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #10692 (3be1a98) into master (f360b63) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10692   +/-   ##
=======================================
  Coverage   62.14%   62.14%           
=======================================
  Files         828      828           
  Lines       51212    51212           
  Branches     6555     6555           
=======================================
+ Hits        31826    31828    +2     
+ Misses      17702    17699    -3     
- Partials     1684     1685    +1     

@giohappy giohappy self-requested a review February 27, 2023 15:32
@giohappy giohappy merged commit 6e15d4d into master Feb 27, 2023
@giohappy giohappy deleted the ISSUE_10615 branch February 27, 2023 15:32
github-actions bot pushed a commit that referenced this pull request Feb 27, 2023
#10692)

* - [Fixes #10615] Implement fallback language for PyCSW to avoid warnings

* update formating

(cherry picked from commit 6e15d4d)
giohappy pushed a commit that referenced this pull request Feb 28, 2023
#10692) (#10702)

* - [Fixes #10615] Implement fallback language for PyCSW to avoid warnings

* update formating

(cherry picked from commit 6e15d4d)

Co-authored-by: NAGGINDA MARTHA <[email protected]>
@afabiani afabiani added this to the 4.1.0 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.1.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants