Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 4.0.x][Minor] Add autocomplete_fields to maps admin MapL… #10812

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

afabiani
Copy link
Member

…ayer datasets (#10773)

(cherry picked from commit 50c67a5)

Conflicts:

geonode/maps/admin.py

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

…ayer datasets (#10773)

(cherry picked from commit 50c67a5)

# Conflicts:
#	geonode/maps/admin.py
@afabiani afabiani added this to the 4.0.4 milestone Mar 20, 2023
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #10812 (a44e3c4) into 4.0.x (69cafb0) will increase coverage by 19.51%.
The diff coverage is 100.00%.

❗ Current head a44e3c4 differs from pull request most recent head 5853f80. Consider uploading reports for the commit 5853f80 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            4.0.x   #10812       +/-   ##
===========================================
+ Coverage   42.43%   61.95%   +19.51%     
===========================================
  Files         827      827               
  Lines       50916    50920        +4     
  Branches     6556     6556               
===========================================
+ Hits        21606    31545     +9939     
+ Misses      27979    17691    -10288     
- Partials     1331     1684      +353     

@afabiani afabiani self-assigned this Mar 20, 2023
@afabiani afabiani merged commit 5e846ea into 4.0.x Mar 22, 2023
@afabiani afabiani deleted the backport-10773-to-4.0.x branch March 22, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants