Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11494] Implement relations between resources #11565

Merged
merged 12 commits into from
Oct 10, 2023
Merged

Conversation

etj
Copy link
Contributor

@etj etj commented Oct 5, 2023

Implements changes described in #11494

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj requested review from giohappy and mattiagiupponi October 5, 2023 15:11
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 5, 2023
@etj etj marked this pull request as ready for review October 9, 2023 11:46
@etj etj force-pushed the 11494_related_resource branch from d1c7dd4 to 2bd7d75 Compare October 9, 2023 16:14
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #11565 (f5f18b1) into master (8913d8e) will increase coverage by 0.01%.
The diff coverage is 91.56%.

❗ Current head f5f18b1 differs from pull request most recent head 11faa5e. Consider uploading reports for the commit 11faa5e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11565      +/-   ##
==========================================
+ Coverage   62.12%   62.13%   +0.01%     
==========================================
  Files         869      871       +2     
  Lines       51993    51987       -6     
  Branches     6492     6495       +3     
==========================================
+ Hits        32300    32302       +2     
+ Misses      18139    18136       -3     
+ Partials     1554     1549       -5     

@etj etj force-pushed the 11494_related_resource branch from 46b5094 to d079987 Compare October 10, 2023 08:32
@etj etj self-assigned this Oct 10, 2023
giohappy
giohappy previously approved these changes Oct 10, 2023
@etj etj merged commit fbee36c into master Oct 10, 2023
@etj etj deleted the 11494_related_resource branch October 10, 2023 15:52
@giohappy giohappy added this to the 4.2.0 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants