Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12277] Remove the MS catalog service configuration #12278

Merged
merged 5 commits into from
May 29, 2024

Conversation

giohappy
Copy link
Contributor

@giohappy giohappy commented May 28, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@giohappy giohappy requested a review from mattiagiupponi May 28, 2024 14:51
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label May 28, 2024
@giohappy giohappy self-assigned this May 28, 2024
@giohappy giohappy added the backport 4.3.x backport to 4.3.x label May 28, 2024
@mattiagiupponi
Copy link
Contributor

the format is not valid @giohappy

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.13%. Comparing base (33ea4b9) to head (6b1514e).
Report is 2 commits behind head on master.

Current head 6b1514e differs from pull request most recent head 3634db0

Please upload reports for the commit 3634db0 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12278   +/-   ##
=======================================
  Coverage   64.13%   64.13%           
=======================================
  Files         872      872           
  Lines       52319    52328    +9     
  Branches     6480     6478    -2     
=======================================
+ Hits        33553    33562    +9     
- Misses      17275    17278    +3     
+ Partials     1491     1488    -3     

@giohappy giohappy merged commit 0bc2fe2 into master May 29, 2024
15 checks passed
@giohappy giohappy deleted the remove_mapstore_services_config branch May 29, 2024 09:58
github-actions bot pushed a commit that referenced this pull request May 29, 2024
* Removed MS catalog service configuration

* fixed formatting

* Fixed test that was expected to fail (?)

* Fixed test that was expected to fail 2 (?)

(cherry picked from commit 0bc2fe2)
giohappy added a commit that referenced this pull request May 29, 2024
…12284)

* Removed MS catalog service configuration

* fixed formatting

* Fixed test that was expected to fail (?)

* Fixed test that was expected to fail 2 (?)

(cherry picked from commit 0bc2fe2)

Co-authored-by: Giovanni Allegri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.3.x backport to 4.3.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the default configuration of the catalog service for the MapStore catalog plugin
2 participants